All of lore.kernel.org
 help / color / mirror / Atom feed
From: Allison Henderson <achender@linux.vnet.ibm.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/6 v7] ext4: fix 1k block bugs
Date: Wed, 07 Sep 2011 11:41:14 -0700	[thread overview]
Message-ID: <4E67BACA.4040600@linux.vnet.ibm.com> (raw)
In-Reply-To: <4E664C83.2080001@linux.vnet.ibm.com>

On 09/06/2011 09:38 AM, Allison Henderson wrote:
> On 09/05/2011 09:59 PM, Ted Ts'o wrote:
>> Allison,
>>
>> Many, many thanks for your work on this patch series!! It's clearly
>> been a very long slog.
>>
>> I've pulled in the first three patches, since I think those are
>> clearly correct at this point. One minor change I've made was I fixed
>> the spelling the flag, which I channged to
>> EXT4_DISCARD_PARTIAL_PG_ZERO_UNMAPPED. (Sorry, but seeing MAPED
>> everywhere was just grating on my nerves. :-)
>>
>> I didn't want to apply your 4th patch in the series since we're
>> planning on reducing the usage of i_mutex in the fs/ext4 code proper,
>> as recommended by Christoph. It wasn't immediately obvious to me
>> whether it was safe to apply any of the patches after #4, so for now
>> I've just merged in the first three, since they clearly fix real
>> problems that show up in xfstests.
>>
>> Can you comment on whether patches #5, #6, and #7 depend on #4?
>>
>> Thanks,
>>
>> - Ted
>
> Hi Ted,
>
> Patches 5 and 6 do not depend on 4, and this set only has 6 patches, so
> no need to worry about patch 7 :) So it is ok to just skip patch 4, I
> will see if I can find another way to solve the race conditions
> Yongqiang pointed out with out the use of i_mutex. Many thanks to you
> too for all the help along the way. :)
>
> Allison Henderson
>

Hi Ted,

I've been working on another way to resolve the punch hole races with 
out i_mutex, and Im starting to think that maybe we're going to need 
another semaphore some where.  Can I ask what the plans are for reducing 
the usage of i_mutex in ext4?  I wasnt sure if someone might already be 
doing this.  Thx!

Allison Henderson

>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html


      reply	other threads:[~2011-09-07 18:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-31  0:28 [PATCH 0/6 v7] ext4: fix 1k block bugs Allison Henderson
2011-08-31  0:28 ` [PATCH 1/6 v7] ext4: Add new ext4_discard_partial_page_buffers routines Allison Henderson
2011-08-31  0:28 ` [PATCH 2/6 v7] ext4: fix xfstests 75, 112, 127 punch hole failure Allison Henderson
2011-08-31  0:28 ` [PATCH 3/6 v7] ext4: fix 2nd xfstests " Allison Henderson
2011-08-31  0:28 ` [PATCH 4/6 v7] ext4: Lock i_mutex for punch hole Allison Henderson
2011-08-31  0:31   ` Andreas Dilger
2011-08-31 18:49     ` Allison Henderson
2011-08-31 19:44       ` Andreas Dilger
2011-08-31  0:28 ` [PATCH 5/6 v7] ext4: fix fsx truncate failure Allison Henderson
2011-08-31  0:28 ` [PATCH 6/6 v7] ext4: fix partial page writes Allison Henderson
2011-09-06  4:59 ` [PATCH 0/6 v7] ext4: fix 1k block bugs Ted Ts'o
2011-09-06 16:38   ` Allison Henderson
2011-09-07 18:41     ` Allison Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E67BACA.4040600@linux.vnet.ibm.com \
    --to=achender@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.