From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817Ab1IHEX2 (ORCPT ); Thu, 8 Sep 2011 00:23:28 -0400 Received: from mail-gy0-f174.google.com ([209.85.160.174]:45645 "EHLO mail-gy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902Ab1IHEX1 (ORCPT ); Thu, 8 Sep 2011 00:23:27 -0400 Message-ID: <4E684331.501@gmail.com> Date: Thu, 08 Sep 2011 12:23:13 +0800 From: Wang Sheng-Hui User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: Jens Axboe , linux-kernel@vger.kernel.org Subject: Re: [PATCH] elevator.c: use ELV_NAME_MAX instead of magic number 16 for chosen_elevator References: <4E637BA8.6030300@gmail.com> In-Reply-To: <4E637BA8.6030300@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2011年09月04日 21:22, Wang Sheng-Hui wrote: > We have ELV_NAME_MAX defined to 16, and hence we should use it > instead of the magic nubmer 16 for elevator's name string. > > The patch is against 3.1-rc3. > > Signed-off-by: Wang Sheng-Hui > --- > block/elevator.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/block/elevator.c b/block/elevator.c > index a3b64bc..cb332cb 100644 > --- a/block/elevator.c > +++ b/block/elevator.c > @@ -182,7 +182,7 @@ static void elevator_attach(struct request_queue *q, struct elevator_queue *eq, > eq->elevator_data = data; > } > > -static char chosen_elevator[16]; > +static char chosen_elevator[ELV_NAME_MAX]; > > static int __init elevator_setup(char *str) > { Any comment?