From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Keng-Yu Lin <kengyu@canonical.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] achi, ata_generic: Add ASMedia ASM1061 support
Date: Thu, 08 Sep 2011 14:36:53 +0400 [thread overview]
Message-ID: <4E689AC5.7020802@ru.mvista.com> (raw)
In-Reply-To: <1315453426-8796-1-git-send-email-kengyu@canonical.com>
Hello.
On 08-09-2011 7:43, Keng-Yu Lin wrote:
> ASM1061 PCI-E to SATA bridge controller has two variants.
> One works under AHCI and the other works with ata_generic.
> Add the PCI vendor ID and product IDs accordingly.
> Signed-off-by: Keng-Yu Lin<kengyu@canonical.com>
[...]
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index f8910e1..87182b8 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2844,3 +2844,7 @@
>
> #define PCI_VENDOR_ID_XEN 0x5853
> #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001
> +
> +#define PCI_VENDOR_ID_ASMEDIA 0x1b21
> +#define PCI_DEVICE_ID_ASM1061_IDE 0x0611
> +#define PCI_DEVICE_ID_ASM1061_AHCI 0x0612
Adding new device IDs to that file is frowned upon. Define the device ID
locally in the driver file, if you must. You don't even use the second one.
WBR, Sergei
prev parent reply other threads:[~2011-09-08 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 3:43 [PATCH] achi, ata_generic: Add ASMedia ASM1061 support Keng-Yu Lin
2011-09-08 9:40 ` Alan Cox
2011-09-08 10:36 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E689AC5.7020802@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=jbarnes@virtuousgeek.org \
--cc=jgarzik@pobox.com \
--cc=kengyu@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.