From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933609Ab1IIMcc (ORCPT ); Fri, 9 Sep 2011 08:32:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56757 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933544Ab1IIMca (ORCPT ); Fri, 9 Sep 2011 08:32:30 -0400 Message-ID: <4E6A075C.1050102@suse.cz> Date: Fri, 09 Sep 2011 14:32:28 +0200 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: Arnaud Lacombe Cc: Nicolas Pitre , linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lkml Subject: Re: [RFC] Kbuild: allow code re-use across different directories References: <1313800642-32418-1-git-send-email-lacombar@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9.9.2011 03:22, Arnaud Lacombe wrote: > Hi, > > On Thu, Sep 8, 2011 at 4:33 PM, Nicolas Pitre wrote: >> On Thu, 8 Sep 2011, Arnaud Lacombe wrote: >> >>> you missed: >>> >>> # Make sure files are removed during clean >>> -extra-y += piggy.gzip piggy.lzo piggy.lzma lib1funcs.S >>> +extra-y += piggy.gzip piggy.lzo piggy.lzma >>> >>> This confused make. >> >> Well... that was suttle. >> > he, welcome to make(1) world :) > >> So yes, your patch may certainly be useful to a couple cases, and it >> works fine for this lib1func.S. >> >> It doesn't help me much in the following situation though. What I >> actually want to achieve is to compile arch/arm/boot/compressed/fdt_rw.o >> from scripts/dtc/libfdt/fdt_rw.c, however I want it to include my local >> version of libfdt_env.h rather than scripts/dtc/libfdt/libfdt_env.h. I >> still haven't found a way to convince gcc to do that. >> > The only choice you have in gcc, is to use -I-, to construct: > > $(CROSS_COMPILE)gcc -I$(srctree)/arch/arm/boot/compressed -I- [...] > > however, it's been marked as deprecated, but still usable as of today > snapshot of 4.7.0. Its replacement, -iquote, do not provide this > functionnality, that is to override the source file origin directory > as search directory for #include "...". Or you modify libfdt to support -DLIBFDT_ENV=libfdt_arm.h or similar. Michal From mboxrd@z Thu Jan 1 00:00:00 1970 From: mmarek@suse.cz (Michal Marek) Date: Fri, 09 Sep 2011 14:32:28 +0200 Subject: [RFC] Kbuild: allow code re-use across different directories In-Reply-To: References: <1313800642-32418-1-git-send-email-lacombar@gmail.com> Message-ID: <4E6A075C.1050102@suse.cz> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 9.9.2011 03:22, Arnaud Lacombe wrote: > Hi, > > On Thu, Sep 8, 2011 at 4:33 PM, Nicolas Pitre wrote: >> On Thu, 8 Sep 2011, Arnaud Lacombe wrote: >> >>> you missed: >>> >>> # Make sure files are removed during clean >>> -extra-y += piggy.gzip piggy.lzo piggy.lzma lib1funcs.S >>> +extra-y += piggy.gzip piggy.lzo piggy.lzma >>> >>> This confused make. >> >> Well... that was suttle. >> > he, welcome to make(1) world :) > >> So yes, your patch may certainly be useful to a couple cases, and it >> works fine for this lib1func.S. >> >> It doesn't help me much in the following situation though. What I >> actually want to achieve is to compile arch/arm/boot/compressed/fdt_rw.o >> from scripts/dtc/libfdt/fdt_rw.c, however I want it to include my local >> version of libfdt_env.h rather than scripts/dtc/libfdt/libfdt_env.h. I >> still haven't found a way to convince gcc to do that. >> > The only choice you have in gcc, is to use -I-, to construct: > > $(CROSS_COMPILE)gcc -I$(srctree)/arch/arm/boot/compressed -I- [...] > > however, it's been marked as deprecated, but still usable as of today > snapshot of 4.7.0. Its replacement, -iquote, do not provide this > functionnality, that is to override the source file origin directory > as search directory for #include "...". Or you modify libfdt to support -DLIBFDT_ENV=libfdt_arm.h or similar. Michal