From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45850)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nick@bytemark.co.uk>) id 1R22Qs-0001vZ-8l
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 10:51:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <nick@bytemark.co.uk>) id 1R22Qm-0005OS-KU
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 10:51:54 -0400
Received: from egg.sh.bytemark.co.uk ([212.110.161.171]:50272)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <nick@bytemark.co.uk>) id 1R22Qm-0005Nu-D5
	for qemu-devel@nongnu.org; Fri, 09 Sep 2011 10:51:48 -0400
Message-ID: <4E6A2800.7010302@bytemark.co.uk>
Date: Fri, 09 Sep 2011 15:51:44 +0100
From: Nicholas Thomas <nick@bytemark.co.uk>
MIME-Version: 1.0
References: <1315495505-28906-1-git-send-email-pbonzini@redhat.com>
	<4E69D595.8090000@redhat.com> <4E69EA89.6090706@redhat.com>
	<1315565422.30081.14.camel@desk4.office.bytemark.co.uk>
	<4E69F2C2.8010003@redhat.com>
In-Reply-To: <4E69F2C2.8010003@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/12] nbd improvements
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 09/09/11 12:04, Kevin Wolf wrote:

> Good to see agreement here. Do you think that Paolo's patches need to be
> changed or can we do everything else on top?

A few things have come up on a third read, actually. I'll respond in due
course to the appropriate patch.

> We do have some timer stubs in qemu-tool.c since May. Of course, they
> are just stubs and never really trigger the timer, but I assume that the
> timeouts are really meant for qemu proper anyway, rather than qemu-img
> or qemu-io.

I wasn't aware of these - however, using them would make testing
timeout/reconnect quite a bit harder. And surely there are use cases of
qemu-img that would benefit from automatic reconnection?

I can work around the former, and we don't actually use qemu-img for
anything ourselves, so if you think this is the right way to go about
it, I'm happy to rework the timeout/reconnect using QEMUTimer, on top of
Paolo's patches.

/Nick