From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32OY-0000IL-0x for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:01:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R32OO-00022r-QK for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:01:37 -0400 Received: from thoth.sbs.de ([192.35.17.2]:27079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32OO-000229-Fs for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:01:28 -0400 Message-ID: <4E6DCA61.4070009@siemens.com> Date: Mon, 12 Sep 2011 11:01:21 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E6DAA09.1050701@twiddle.net> In-Reply-To: <4E6DAA09.1050701@twiddle.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: Blue Swirl , qemu-devel , Avi Kivity On 2011-09-12 08:43, Richard Henderson wrote: > On 09/11/2011 09:31 PM, Blue Swirl wrote: >> Field 'offset' is always zero, maybe that is not interesting. Will it >> become one day? > > It's not always zero, but only used by certain devices. I do not see any users, neither upstream nor in Avi's tree. To my (semi-)understanding, offset should correlate to region_offset of cpu_register_physical_memory_offset: legacy device models require this to be 0 as they expect an absolute memory address passed to their handler, in contrast to a normal one that is relative to the regions base. But I do not see how the memory region offset actually helps here. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux