From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57859) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32YJ-0004EI-3B for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:11:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R32YF-0004fR-72 for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:11:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R32YF-0004fM-0A for qemu-devel@nongnu.org; Mon, 12 Sep 2011 05:11:39 -0400 Message-ID: <4E6DCCC4.1050201@redhat.com> Date: Mon, 12 Sep 2011 12:11:32 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E6DAA09.1050701@twiddle.net> <4E6DCA61.4070009@siemens.com> In-Reply-To: <4E6DCA61.4070009@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Blue Swirl , qemu-devel , Richard Henderson On 09/12/2011 12:01 PM, Jan Kiszka wrote: > On 2011-09-12 08:43, Richard Henderson wrote: > > On 09/11/2011 09:31 PM, Blue Swirl wrote: > >> Field 'offset' is always zero, maybe that is not interesting. Will it > >> become one day? > > > > It's not always zero, but only used by certain devices. > > I do not see any users, neither upstream nor in Avi's tree. There aren't. > To my (semi-)understanding, offset should correlate to region_offset of > cpu_register_physical_memory_offset: legacy device models require this > to be 0 as they expect an absolute memory address passed to their > handler, in contrast to a normal one that is relative to the regions > base. But I do not see how the memory region offset actually helps here. > mr->offset is added to the address in memory_region_{read,write}_thunk_n(). -- error compiling committee.c: too many arguments to function