From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44320)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R3Ugk-0002qU-LE
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:14:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R3Ugb-0006AI-9Z
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:14:18 -0400
Received: from mail-vw0-f46.google.com ([209.85.212.46]:33304)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1R3Ugb-0006AD-5v
	for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:14:09 -0400
Received: by vws1 with SMTP id 1so1292764vws.33
	for <qemu-devel@nongnu.org>; Tue, 13 Sep 2011 08:14:08 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4E6F733B.6070001@redhat.com>
Date: Tue, 13 Sep 2011 17:14:03 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1315495505-28906-1-git-send-email-pbonzini@redhat.com>
	<1315495505-28906-7-git-send-email-pbonzini@redhat.com>
	<4E6F6194.3020305@redhat.com>
In-Reply-To: <4E6F6194.3020305@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/12] nbd: support NBD_CMD_TRIM in the
	server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On 09/13/2011 03:58 PM, Kevin Wolf wrote:
>> >  +    case NBD_CMD_TRIM:
>> >  +        TRACE("Request type is TRIM");
>> >  +        bdrv_discard(bs, (request.from + dev_offset) / 512,
>> >  +                     request.len / 512);
>
> Errors are completely ignored? Does the NBD protocol not allow to return
> an error?

Actually it does, will fix.

Paolo