From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3UzE-0007iJ-RB for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3UzD-0001l7-T7 for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:33:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3UzD-0001l3-Jd for qemu-devel@nongnu.org; Tue, 13 Sep 2011 11:33:23 -0400 Message-ID: <4E6F7873.2060001@redhat.com> Date: Tue, 13 Sep 2011 17:36:19 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <871uvquxi0.wl%morita.kazutaka@lab.ntt.co.jp> <1315555898-16957-1-git-send-email-pbonzini@redhat.com> <4E6F652C.7080103@redhat.com> <4E6F73E5.3020303@redhat.com> In-Reply-To: <4E6F73E5.3020303@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/12] sheepdog: move coroutine send/recv function to generic code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, MORITA Kazutaka Am 13.09.2011 17:16, schrieb Paolo Bonzini: > On 09/13/2011 04:14 PM, Kevin Wolf wrote: >>>> block/sheepdog.c | 225 ++++++------------------------------------------------ >>>> cutils.c | 103 +++++++++++++++++++++++++ >>>> qemu-common.h | 3 + >>>> qemu-coroutine.c | 70 +++++++++++++++++ >>>> qemu-coroutine.h | 26 ++++++ >> >> Can we move the code somewhere else? This is not core coroutine >> infrastructure. I would suggest qemu_socket.h/qemu-sockets.c. > > It's not really socket-specific either (it uses recv/send only because > of Windows brokenness---it could use read/write if it wasn't for that). > I hoped sooner or later it could become a qemu_co_readv/writev, hence > the choice of qemu-coroutine.c. > > Paolo > > ps: I also hope that the Earth will start spinning slower and will give > me 32 hour days, so just tell me if you really want that outside > qemu-coroutine.c. Yes, I do want it outside qemu-coroutine.c. If you prefer putting it next to qemu_write_full() and friends rather than into the sockets file, feel free to do that. Kevin