From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3mac-0002AB-2I for qemu-devel@nongnu.org; Wed, 14 Sep 2011 06:21:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R3maa-0005yy-V6 for qemu-devel@nongnu.org; Wed, 14 Sep 2011 06:21:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R3maa-0005yn-NW for qemu-devel@nongnu.org; Wed, 14 Sep 2011 06:21:08 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p8E9lVCI024137 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 14 Sep 2011 05:47:32 -0400 Message-ID: <4E7078DC.5020609@redhat.com> Date: Wed, 14 Sep 2011 11:50:20 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1315495505-28906-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1315495505-28906-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/12] nbd improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Am 08.09.2011 17:24, schrieb Paolo Bonzini: > I find nbd quite useful to test migration, but it is limited: > it can only do synchronous operation, it is not safe because it > does not support flush, and it has no discard either. qemu-nbd > is also limited to 1MB requests, and the nbd block driver does > not take this into account. > > Luckily, flush/FUA support is being worked out by upstream, > and discard can also be added with the same framework (patches > 1 to 6). > > Asynchronous support is also very similar to what sheepdog is > already doing (patches 7 to 12). > > Paolo Bonzini (12): > nbd: support feature negotiation > nbd: sync API definitions with upstream > nbd: support NBD_SET_FLAGS ioctl > nbd: add support for NBD_CMD_FLUSH > nbd: add support for NBD_CMD_FLAG_FUA > nbd: support NBD_CMD_TRIM in the server > sheepdog: add coroutine_fn markers > add socket_set_block > sheepdog: move coroutine send/recv function to generic code > block: add bdrv_co_flush support > nbd: switch to asynchronous operation > nbd: split requests Okay, completed the review for this series now. I think if you consider the comments posted so far for v2 we should be good. Kevin