From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46489)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3uA9-0004OU-Pl
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 14:26:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3uA8-0007QH-M8
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 14:26:21 -0400
Received: from mail-vw0-f51.google.com ([209.85.212.51]:45930)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1R3uA8-0007Q4-IS
	for qemu-devel@nongnu.org; Wed, 14 Sep 2011 14:26:20 -0400
Received: by vws20 with SMTP id 20so3199164vws.10
	for <qemu-devel@nongnu.org>; Wed, 14 Sep 2011 11:26:20 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E70F1C9.7000407@twiddle.net>
Date: Wed, 14 Sep 2011 11:26:17 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <CAAu8pHvpbYBuOKa6Krsd6R00qidBx+J6ObaqZT40zuYh+SZn9g@mail.gmail.com>
	<4E6DAA09.1050701@twiddle.net> <4E6DCA61.4070009@siemens.com>
	<4E6DCCC4.1050201@redhat.com> <4E6DCE8D.9040602@siemens.com>
	<4E70C402.3090907@twiddle.net> <4E70EB39.4010101@siemens.com>
In-Reply-To: <4E70EB39.4010101@siemens.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 09/14/2011 10:58 AM, Jan Kiszka wrote:
>> It would also be used when we split an ISA portio region, as 
>> with the FDC device.  There, we have 7 ports in 2 chunks.  The
>> offset would still be needed to convert the relative offset of
>> the second chuck to be relative to the "real" un-split region.
> 
> That sounds a lot like it only affects the flattened representation, and
> there an offset does make sense. But we are discussing the original
> memory regions here that should not require it (provided the above
> cleanup is applicable).

These *are* the original memory regions, not something flattened.
The legacy isa port numbers for FDC and IDE are, sadly, interleaved.

>> Feel free to convert all of these devices to a more "native" use
>> of the memory api, but I warn you it won't be trivial.
> 
> Do you mean VGA and GUS or FDC?

VGA and GUS are non-trivial.  FDC would be fairly easy.


r~