From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4A0j-0002sv-To for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:21:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R4A0i-0008Pk-Qm for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:21:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R4A0i-0008Pc-Dp for qemu-devel@nongnu.org; Thu, 15 Sep 2011 07:21:40 -0400 Message-ID: <4E71DFBF.6090106@redhat.com> Date: Thu, 15 Sep 2011 14:21:35 +0300 From: Avi Kivity MIME-Version: 1.0 References: <4E6DAA09.1050701@twiddle.net> <4E6DCA61.4070009@siemens.com> <4E6DCCC4.1050201@redhat.com> <4E6DCE8D.9040602@siemens.com> <4E70C402.3090907@twiddle.net> <4E70EB39.4010101@siemens.com> <4E70EDFF.4000008@siemens.com> <4E70FF6A.8050401@redhat.com> <4E71C5BF.7050409@siemens.com> <4E71CB19.2010605@redhat.com> <4E71D0F1.9020805@siemens.com> In-Reply-To: <4E71D0F1.9020805@siemens.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] memory: simple memory tree printer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Blue Swirl , qemu-devel , Richard Henderson On 09/15/2011 01:18 PM, Jan Kiszka wrote: > On 2011-09-15 11:53, Avi Kivity wrote: > >>> The host pci bridge remaps this as > >>> 0x1000000105-0x1000000106 in the memory address space space. But > >>> someone configured a cpu-local region at this address, so the cpu can't > >>> reach it at all. > >> > >> Mapping PIO into MMIO space is special as it needs an intermediate layer > >> (ie. translation handlers). > > > > Translation handlers aren't needed - you can simply add the pci pio > > region as a subregion of the mmio space. > > From the outer perspective. But internally, there is still > memory_region_iorange_read/write. These will go away. > The point is that no use case actually justifies memory_region_set_offset. > It's just a compatibility interface. When everything is converted, and no users remain, we'll remove it. -- error compiling committee.c: too many arguments to function