From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avg@FreeBSD.org>) id 1R4a5Z-0007l1-6I
	for qemu-devel@nongnu.org; Fri, 16 Sep 2011 11:12:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avg@FreeBSD.org>) id 1R4a5U-00007x-NM
	for qemu-devel@nongnu.org; Fri, 16 Sep 2011 11:12:25 -0400
Received: from citadel.icyb.net.ua ([212.40.38.140]:1624)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avg@FreeBSD.org>) id 1R4a5U-00007E-3r
	for qemu-devel@nongnu.org; Fri, 16 Sep 2011 11:12:20 -0400
Message-ID: <4E736749.6020508@FreeBSD.org>
Date: Fri, 16 Sep 2011 18:12:09 +0300
From: Andriy Gapon <avg@FreeBSD.org>
MIME-Version: 1.0
References: <4E72809B.8000209@web.de>
In-Reply-To: <4E72809B.8000209@web.de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vga: Fix text mode screendumps
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

on 16/09/2011 01:47 Jan Kiszka said the following:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> In text mode, even a full refresh of the screen takes multiple updates.
> As we reset the dump file pointer after the first call, we only wrote
> the first line.

Thank you very much!
I can confirm that with the patch I get a complete screen dump.

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/vga.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/vga.c b/hw/vga.c
> index 0a0c5a6..f9a6014 100644
> --- a/hw/vga.c
> +++ b/hw/vga.c
> @@ -149,7 +149,7 @@ static uint16_t expand2[256];
>  static uint8_t expand4to8[16];
>  
>  static void vga_screen_dump(void *opaque, const char *filename);
> -static char *screen_dump_filename;
> +static const char *screen_dump_filename;
>  static DisplayChangeListener *screen_dump_dcl;
>  
>  static void vga_update_memory_access(VGACommonState *s)
> @@ -2319,7 +2319,6 @@ static void vga_save_dpy_update(DisplayState *ds,
>  {
>      if (screen_dump_filename) {
>          ppm_save(screen_dump_filename, ds->surface);
> -        screen_dump_filename = NULL;
>      }
>  }
>  
> @@ -2397,8 +2396,8 @@ static void vga_screen_dump(void *opaque, const char *filename)
>      if (!screen_dump_dcl)
>          screen_dump_dcl = vga_screen_dump_init(s->ds);
>  
> -    screen_dump_filename = (char *)filename;
> +    screen_dump_filename = filename;
>      vga_invalidate_display(s);
>      vga_hw_update();
> +    screen_dump_filename = NULL;
>  }
> -


-- 
Andriy Gapon