From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39420)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1R52WK-0006ec-IW
	for qemu-devel@nongnu.org; Sat, 17 Sep 2011 17:33:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1R52WJ-0003Ud-ID
	for qemu-devel@nongnu.org; Sat, 17 Sep 2011 17:33:56 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:35577)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1R52WJ-0003UT-Ac
	for qemu-devel@nongnu.org; Sat, 17 Sep 2011 17:33:55 -0400
Message-ID: <4E751240.5010803@mail.berlios.de>
Date: Sat, 17 Sep 2011 23:33:52 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <4E74FC29.1050003@mail.berlios.de>	<1316289634-18786-8-git-send-email-weil@mail.berlios.de>
	<CAFEAcA_Ns6gRtNsU3Uzp1zGeek1TKnMaH4_LHNrjZzO58qrT8w@mail.gmail.com>
In-Reply-To: <CAFEAcA_Ns6gRtNsU3Uzp1zGeek1TKnMaH4_LHNrjZzO58qrT8w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 8/8] ppc: Support tcg interpreter on ppc
 hosts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Am 17.09.2011 23:31, schrieb Peter Maydell:
> On 17 September 2011 21:00, Stefan Weil<weil@mail.berlios.de>  wrote:
>> Tests of the tcg interpreter on an (emulated) ppc host
>> needed this small change.
>>
>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>> ---
>>   cache-utils.h |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/cache-utils.h b/cache-utils.h
>> index 0b65907..7c3b282 100644
>> --- a/cache-utils.h
>> +++ b/cache-utils.h
>> @@ -1,7 +1,7 @@
>>   #ifndef QEMU_CACHE_UTILS_H
>>   #define QEMU_CACHE_UTILS_H
>>
>> -#if defined(_ARCH_PPC)
>> +#if defined(_ARCH_PPC)&&  !defined(CONFIG_TCG_INTERPRETER)
>>   struct qemu_cache_conf {
>>      unsigned long dcache_bsize;
>>      unsigned long icache_bsize;
> This looks a bit odd, but I think that's partly an effect of
> only the PPC flush_icache_range being in this header file when
> for other architectures it is in tcg/*/tcg-target.h. If we
> could have the cache flushing be in tcg/* for every target then
> you wouldn't need to do an ifdef here.
>
> -- PMM

That's correct.