From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54308)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R5Yjc-00016y-3L
	for qemu-devel@nongnu.org; Mon, 19 Sep 2011 03:57:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R5YjX-00017I-Kp
	for qemu-devel@nongnu.org; Mon, 19 Sep 2011 03:57:48 -0400
Received: from david.siemens.de ([192.35.17.14]:17335)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1R5YjX-00017B-9o
	for qemu-devel@nongnu.org; Mon, 19 Sep 2011 03:57:43 -0400
Message-ID: <4E76F5F2.7000204@siemens.com>
Date: Mon, 19 Sep 2011 09:57:38 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1316361891-8960-1-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1316361891-8960-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] isapc: give system address space when pci
	is disabled
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org

On 2011-09-18 18:04, Herv=C3=A9 Poussineau wrote:
>=20
> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
> ---
>  hw/pc_piix.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index da6fa55..c0b8a3a 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -121,7 +121,7 @@ static void pc_init1(MemoryRegion *system_memory,
>          pc_memory_init(system_memory,
>                         kernel_filename, kernel_cmdline, initrd_filenam=
e,
>                         below_4g_mem_size, above_4g_mem_size,
> -                       pci_memory, &ram_memory);
> +                       pci_enabled ? pci_memory : system_memory, &ram_=
memory);
>      }
> =20
>      if (!xen_enabled()) {

Makes sense. I guess we should rename 'pci_memory' inside pc_memory_init
to reflect this - 'rom_memory'?

But -M isapc still only gives me a black screen. Are there further fixes
required?

Jan

--=20
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux