All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Schwarz <simonschwarzcor@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] SMDK6400 regression
Date: Wed, 21 Sep 2011 11:13:41 +0200	[thread overview]
Message-ID: <4E79AAC5.9000803@gmail.com> (raw)
In-Reply-To: <4E7836F4.7000903@aribaud.net>

On 09/20/2011 08:47 AM, Albert ARIBAUD wrote:
> Copying Simon as the author of the commit, in order to confirm that the
> issue is in smdk6400.

The problem is that I added a nand_read_buf prototype in nand.h this was 
defined static in nand_base.c - I removed the static declaration. 
smdk6400 is defining the exact same functions in its SPL but they are 
static.

Dublicated code like this was the reason for my changes.

I can provide a quickfix by just remove the static from the 
smdk6400-functions. But IMHO it is more sensible to write a proper 
header for most of the functions in nand_base.c and remove the static 
modifier. Then they can be used in SPLs and no one tries to redo/copy 
them again. Scott what's your opinion on that?

Regards
Simon

  parent reply	other threads:[~2011-09-21  9:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-18 23:39 [U-Boot] Please pull u-boot-ti/next s-paulraj at ti.com
2011-09-19  7:15 ` Albert ARIBAUD
2011-09-19  7:47   ` Wolfgang Denk
2011-09-19 12:11     ` Albert ARIBAUD
2011-09-19 14:21       ` Paulraj, Sandeep
2011-09-20  6:47         ` [U-Boot] SMDK6400 regression (was: Please pull u-boot-ti/next) Albert ARIBAUD
2011-09-20  7:38           ` [U-Boot] SMDK6400 regression Simon Schwarz
2011-09-21  9:13           ` Simon Schwarz [this message]
2011-09-21 19:35             ` Scott Wood
2011-09-23 16:36               ` [U-Boot] [PATCH RFC] Add general nand functions Simon Schwarz
2011-09-23 16:42                 ` Simon Schwarz
2011-09-23 17:22                 ` Scott Wood
2011-09-26  8:27                   ` Simon Schwarz
2011-09-27  0:28                     ` Scott Wood
2011-09-27 10:09                       ` [U-Boot] [PATCH RFC 1/3] nand: Remove static modifier from common functions Simon Schwarz
2011-09-27 10:09                         ` [U-Boot] [PATCH RFC 2/3] nand: Add common functions to nand.h Simon Schwarz
2011-09-27 10:09                         ` [U-Boot] [PATCH RFC 3/3] Fix regression in SMDK6400 Simon Schwarz
2011-09-27 10:14                       ` [U-Boot] [PATCH RFC] Add general nand functions Simon Schwarz
2011-09-27 22:50                         ` Scott Wood
2011-09-28  8:48                           ` Simon Schwarz
2011-09-20  6:49 ` [U-Boot] Please pull u-boot-ti/next Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E79AAC5.9000803@gmail.com \
    --to=simonschwarzcor@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.