All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Chris Ball <cjb@laptop.org>, Will Newton <will.newton@imgtec.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] mmc: dw_mmc: fix wrong SDMMC_GET_FCNT macro
Date: Mon, 26 Sep 2011 09:05:40 +0100	[thread overview]
Message-ID: <4E803254.9050908@imgtec.com> (raw)
In-Reply-To: <4E8010A0.7060106@samsung.com>

On 09/26/2011 06:41 AM, Jaehoon Chung wrote:
> I understood that SDMMC_GET_FCNT is used to get fifo_count.
> In status register, fifo_count is bit[17:29].
> But this macro is control with bit[17:25].
> 
> i think right that change 0x1FFF instead of 0x1FF.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.Park@samsung.com>

nice catch.

Reviewed-by: James Hogan <james.hogan@imgtec.com>

> ---
>  drivers/mmc/host/dw_mmc.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index bfa3c1c..193ec94 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -117,7 +117,7 @@
>  #define SDMMC_CMD_RESP_EXP		BIT(6)
>  #define SDMMC_CMD_INDX(n)		((n) & 0x1F)
>  /* Status register defines */
> -#define SDMMC_GET_FCNT(x)		(((x)>>17) & 0x1FF)
> +#define SDMMC_GET_FCNT(x)		(((x)>>17) & 0x1FFF)
>  /* Internal DMAC interrupt defines */
>  #define SDMMC_IDMAC_INT_AI		BIT(9)
>  #define SDMMC_IDMAC_INT_NI		BIT(8)


  reply	other threads:[~2011-09-26  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26  5:41 [PATCH] mmc: dw_mmc: fix wrong SDMMC_GET_FCNT macro Jaehoon Chung
2011-09-26  8:05 ` James Hogan [this message]
2011-09-26  9:30   ` Will Newton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E803254.9050908@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=cjb@laptop.org \
    --cc=jh80.chung@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=will.newton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.