From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Mon, 26 Sep 2011 10:28:56 +0200
Subject: [U-Boot] [PATCH 6/8] arm, davinci,
 am1808: add lowlevel functions for booting from NOR
In-Reply-To: <CABkLObo9vVG89JA7BGM9bb85=uCuTWqyJhXv5AQLwV8uj9kt2A@mail.gmail.com>
References: <1316066380-7397-1-git-send-email-hs@denx.de>
	<1316066380-7397-7-git-send-email-hs@denx.de>
	<CABkLObo9vVG89JA7BGM9bb85=uCuTWqyJhXv5AQLwV8uj9kt2A@mail.gmail.com>
Message-ID: <4E8037C8.5020905@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Christian,

Christian Riesch wrote:
> Heiko,
> I am looking forward to see these patches in mainline u-boot. My
> custom board also directly boots from NOR, so I think there is a lot I
> can re-use for my board.

Thats the goal ;-)

> I have one question, please see below:
[...]
>> +void am1808_lpc_transition(unsigned char pscnum, unsigned char module,
>> +               unsigned char domain, unsigned char state)
>> +{
[...]
>> +       /* Wait for transition to complete */
>> +       while (readl(&reg->ptstat) & (0x00000001 << domain))
>> +               ;
>> +
>> +       /* Wait and verify the state */
>> +       while ((readl(mdstat) & 0x1F) != state)
>> +               ;
>> +}
> 
> There is some similar code in arch/arm/cpu/arm926ejs/davinci/psc.c. Is
> there any reason why you don't use this code or adapt it for your
> needs?

No, there is no reason, just missed it! I try the functions in
arch/arm/cpu/arm926ejs/davinci/psc.c and if they work, I remove the
am1808_lpc_transition function.

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany