From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:49280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R888x-0003CS-Ri
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 06:10:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R888w-0002Ij-Kf
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 06:10:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64847)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1R888w-0002Ic-CR
	for qemu-devel@nongnu.org; Mon, 26 Sep 2011 06:10:34 -0400
Message-ID: <4E804F93.5060802@redhat.com>
Date: Mon, 26 Sep 2011 13:10:27 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4E7A828A.3030404@codemonkey.ws>
	<CAAu8pHs7uMeusg1PoMkDrxew6WzOaSGJJJgtbDAwwwKwYeGx_Q@mail.gmail.com>
	<4E7F366F.9060501@redhat.com>
	<CAAu8pHtu4OaCniMC8+UC9oxKkyJoUgwBGsOadBWE7G9E8-+B7g@mail.gmail.com>
	<4E7F5B62.1090307@redhat.com>
	<CAAu8pHuoP2hpMOBh91DTG_SS5jtwLVgWiTJqnb14kS+EJmFhXw@mail.gmail.com>
	<4E804F20.2090007@redhat.com>
In-Reply-To: <4E804F20.2090007@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [FYI] Soft feature freeze for 1.0 is 10/15 (three
 weeks away)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 09/26/2011 01:08 PM, Avi Kivity wrote:
> On 09/25/2011 08:31 PM, Blue Swirl wrote:
>> >
>> >  Please point out a test case and I'll try to fix it.
>>
>> Run qemu-system-ppc without any arguments. There is a black bar
>> (because of vga.chain4), it shouldn't be there.
>
> With your pci hole patch, it's fixed, except for:
>
>     escc_mem = escc_init(0x80013000, pic[0x25], pic[0x24],
>                          serial_hds[0], serial_hds[1], ESCC_CLOCK, 4)
>
> This puts escc bang into the framebuffer.  Changing it to 0x90013000 
> makes the black bar go away.
>
> Before the memory API, this worked, likely because the framebuffer 
> overlays escc.
>
> The correct fix depends on what the hardware does.  Is escc really 
> registered into the pci area, and again as a BAR?
>

If we reenable the collision warning in memory.c, we see

   warning: subregion collision 80013000/40 (escc) vs 80000000/70000000 
(pci-hole)

I'll work on reenabling ir permanently.

-- 
error compiling committee.c: too many arguments to function