From mboxrd@z Thu Jan  1 00:00:00 1970
From: Helmut Raiger <helmut.raiger@hale.at>
Date: Thu, 29 Sep 2011 09:30:49 +0200
Subject: [U-Boot] [PATCH] mx31: provide readable WEIM CS accessor
In-Reply-To: <4E8339E9.3080204@denx.de>
References: <20110922140833.CF0B6140796D@gemini.denx.de>
	<1317214100-1379-1-git-send-email-helmut.raiger@hale.at>
	<1317214100-1379-2-git-send-email-helmut.raiger@hale.at>
	<4E8339E9.3080204@denx.de>
Message-ID: <4E841EA9.7070001@hale.at>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 09/28/2011 05:14 PM, Stefano Babic wrote:
>> +#ifndef __ASSEMBLER__
>> +static inline void mx31_setup_weimcs(int cs,
> Is there a reason to embed this function in imx-regs.h ? Why not in
> ./arch/arm/cpu/arm1136/mx31/generic.c, where I think this function
> belongs ?
>

I re-checked, it makes a lot of sense to inline this function as it 
results into 3 simple register writes (addresses are compile time 
calculated if 'cs' is a constant)!

Helmut




--
Scanned by MailScanner.