From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755613Ab1JDJqx (ORCPT <rfc822;w@1wt.eu>);
	Tue, 4 Oct 2011 05:46:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22247 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755436Ab1JDJqw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 4 Oct 2011 05:46:52 -0400
Message-ID: <4E8AD5F4.7000201@redhat.com>
Date: Tue, 04 Oct 2011 11:46:28 +0200
From: Avi Kivity <avi@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2
MIME-Version: 1.0
To: Jon Mason <mason@myri.com>
CC: Sven Schnelle <svens@stackframe.org>, Simon Kirby <sim@hostway.ca>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Niels Ole Salscheider <niels_ole@salscheider-online.de>,
        Jesse Barnes <jbarnes@virtuousgeek.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: Workaround for Intel MPS errata
References: <4E82017C.3010304@redhat.com> <CAPoiz9w4LyTkmAACHQYR5GSJ+TmN7ePJSb-UuRQ7EjY=QYVn5Q@mail.gmail.com> <4E8215B6.1020108@redhat.com> <20110930001633.GA11436@myri.com> <4E882E34.8040409@redhat.com> <20111003045823.GA13222@myri.com> <4E898A69.8060306@redhat.com> <20111003151158.GA21955@myri.com>
In-Reply-To: <20111003151158.GA21955@myri.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/03/2011 05:12 PM, Jon Mason wrote:
>      PCI: Workaround for Intel MPS errata
>
>      Intel 5000 and 5100 series memory controllers have a known issue if read
>      completion coalescing is enabled (the default setting) and the PCI-E
>      Maximum Payload Size is set to 256B.  To work around this issue, disable
>      read completion coalescing if the MPS is 256B.
>
>      It is worth noting that there is no function to undo the disable of read
>      completion coalescing, and the performance benefit of read completion
>      coalescing will be lost if the MPS is set from 256B to 128B.  It is only
>      possible to have this issue via hotplug removing the only 256B MPS
>      device in the system (thus making all of the other devices in the system
>      have a performance degradation without the benefit of any 256B
>      transfers).  Therefore, this trade off is acceptable.
>
>      http://www.intel.com/content/dam/doc/specification-update/5000-chipset-memory-controller-hub-specification-update.pdf
>      http://www.intel.com/content/dam/doc/specification-update/5100-memory-controller-hub-chipset-specification-update.pdf
>
>      Thanks to Jesse Brandeburg and Ben Hutchings for providing insight into
>      the problem.
>
>      Reported-by: Avi Kivity<avi@redhat.com>
>      Signed-off-by: Jon Mason<mason@myri.com>
>
> +
> +		if (!(val&  (1<<  10))) {
> +			done = true;
> +			return;
> +		}

Here, you bail out if bit 10 is clear.  So if we're here, it's set.

> +
> +		val |= (1<<  10);

Now it's even more set?

> +		err = pci_bus_write_config_word(bus, 0, 0x48, val);
> +		if (err) {
> +			dev_err(&bus->dev, "Error attempting to write the read "
> +				"completion coalescing register.\n");
> +			return;
> +		}
> +
> +		dev_info(&bus->dev, "Read completion coalescing disabled due "
> +			 "to hardware errata relating to 256B MPS.\n");
> +
> +		done = true;
> +	}
> +}
> +
>

-- 
error compiling committee.c: too many arguments to function