All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Carsten Otte <cotte@de.ibm.com>, Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] s390: Fix cpu shutdown for KVM
Date: Tue, 04 Oct 2011 16:16:47 +0200	[thread overview]
Message-ID: <4E8B154F.7050007@de.ibm.com> (raw)
In-Reply-To: <CAFEAcA-_dqxwWhuOhsGxXHNfh4bayJZ3tqjCdJ_W174QX-y=DQ@mail.gmail.com>

On 04/10/11 15:56, Peter Maydell wrote:
> On 4 October 2011 14:47, Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>> +     * We can only deliver interrupts to (interrupt) enabled CPUs.
>> +     * We dont call kvm_s390_add_running_cpu here, since CPUs in enabled wait
>> +     * will wait inside the kernel (no exit). Therefore, the targeted
>> +     * CPUs was neither disabled waiting or stopped for qemu.
> 
> Grammar nits, since I'm commenting anyway:
>  "don't"
>  "neither disabled waiting nor stopped"

Ok. Alex can you fix that up or do you want a new patch?

> This makes the ICPT_CPU_STOP and ICPT_WAITPSW cases identical,
> right? You should just fold them together.

Yes, at the moment they are identical.
I am still thinking about some additional changes that will make them separate again
due to their usage in Linux:
- disabled wait usually indicates a kernel panic
- stop is called during cpu hot unplug and during shutdown for the last cpu

So on disabled wait we might want to perform extra logging etc, but I dont know yet.
Should I merge them anyway?

Christian

  reply	other threads:[~2011-10-04 14:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 11:28 [Qemu-devel] s390: Fix cpu shutdown for KVM Christian Borntraeger
2011-10-04 12:10 ` Alexander Graf
2011-10-04 13:47   ` Christian Borntraeger
2011-10-04 13:56     ` Peter Maydell
2011-10-04 14:16       ` Christian Borntraeger [this message]
2011-10-04 14:37     ` Alexander Graf
2011-10-04 15:20       ` [Qemu-devel] [PATCHv3] " Christian Borntraeger
2011-10-04 15:41         ` Alexander Graf
2011-10-04 18:32           ` Christian Borntraeger
2011-10-07  7:28         ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E8B154F.7050007@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=cotte@de.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.