J1939 Linux

J1939 Linux

[Dinesh]

Hi,
I am trying to merge J1939 to linux kernel 3.19.0.52. I download the linux
kernel git repo and added linux-can-j1939.git as remote repo. I am trying to
fetch and facing errors as "certificate verification failed".

1. git clone git://kernel.ubuntu.com/kernel-ppa/mirror/ubuntu-vivid.git
2. git remote add j1939 http://gitorious.org:linux-can/linux-can-j1939.git
3. git remote update j1939
Fetching j1939
fatal: unable to access 'https://gitorious.org/linux-can-j1939.git/': server
certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt
CRLfile: none
error: Could not fetch j1939

Regards
Dinesh

Re: J1939 Linux

[Kurt Van Dijck]

Hey,

> 
> Hi,
> I am trying to merge J1939 to linux kernel 3.19.0.52. I download the linux
> kernel git repo and added linux-can-j1939.git as remote repo. I am trying to
> fetch and facing errors as "certificate verification failed".
> 
> 1. git clone git://kernel.ubuntu.com/kernel-ppa/mirror/ubuntu-vivid.git
> 2. git remote add j1939 http://gitorious.org:linux-can/linux-can-j1939.git

gitorious.org has stopped.
I moved my can-j1939 repositories to https://github.com/kurt-vd/linux.
You would find this reference on http://elinux.org/J1939.
Where did you find the reference to gitorious.org?
I may have forgotten to update a link.

> 3. git remote update j1939
> Fetching j1939
> fatal: unable to access 'https://gitorious.org/linux-can-j1939.git/': server
> certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt
> CRLfile: none
> error: Could not fetch j1939
> 

Kind regards,
Kurt

RE: J1939 Linux

[Dinesh Velayudham]

Kurt,
Thanks for the reply.
After I post this question I got the github information, now that I am able to clone/merge from github.

I am facing lot of merge conflicts.
I am trying to merge Linux-J1939 to Linux kernel from Ubuntu - 3.19.0.56-generic.
Which version of linux-j1939 would you suggest for easy merge? I tried v3.10, v.3.15 and v4.1



Regards
Dinesh Velayudham
L&T Technology Services
dinesh.velayutham@lnttechservices.com
+1-309-740-7691

-----Original Message-----
From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
Sent: Wednesday, April 06, 2016 2:47 AM
To: Dinesh Velayudham
Cc: linux-can@vger.kernel.org
Subject: Re: J1939 Linux

Hey,

>
> Hi,
> I am trying to merge J1939 to linux kernel 3.19.0.52. I download the
> linux kernel git repo and added linux-can-j1939.git as remote repo. I
> am trying to fetch and facing errors as "certificate verification failed".
>
> 1. git clone
> git://kernel.ubuntu.com/kernel-ppa/mirror/ubuntu-vivid.git
> 2. git remote add j1939
> http://gitorious.org:linux-can/linux-can-j1939.git

gitorious.org has stopped.
I moved my can-j1939 repositories to https://github.com/kurt-vd/linux.
You would find this reference on http://elinux.org/J1939.
Where did you find the reference to gitorious.org?
I may have forgotten to update a link.

> 3. git remote update j1939
> Fetching j1939
> fatal: unable to access 'https://gitorious.org/linux-can-j1939.git/':
> server certificate verification failed. CAfile:
> /etc/ssl/certs/ca-certificates.crt
> CRLfile: none
> error: Could not fetch j1939
>

Kind regards,
Kurt
L&T Technology Services Ltd

www.LntTechservices.com<http://www.lnttechservices.com/>

This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

Re: J1939 Linux

[Kurt Van Dijck]

> Kurt,
> Thanks for the reply.
> After I post this question I got the github information, now that I am able to clone/merge from github.

I see.

> 
> I am facing lot of merge conflicts.
> I am trying to merge Linux-J1939 to Linux kernel from Ubuntu - 3.19.0.56-generic.
> Which version of linux-j1939 would you suggest for easy merge? I tried v3.10, v.3.15 and v4.1

I suggest you merge branch j1939d-v3.15

Feel free to let me know if you experience merge conflicts with that
branch. It's completely normal that you have merge conflicts with (most) other
branches.

Kind regards,
Kurt

RE: J1939 Linux

[Dinesh Velayudham]

Kurt,
I am facing deb-pkg error while building the kernel. Need your guidance on that.

Steps below.
1. I cloned the kernel from "http://kernel.ubuntu.com/git/kernel-ppa/mirror/ubuntu-vivid.git/commit/?id=32ac5b4aae56cf9446c30463663c8ae2226069da" with tag name "Ubuntu-3.19.0-56.62"
2. Then I added "git remote add j1939 git://github.com/kurt-vd/linux"
3. git remote update j1939
4. git merge j1939/j1939d-v3.15
5. Merge was successful without any issues.
6. cp /boot/config-3.19.0.56-generic .config
7. yes ' ' | make oldconfig
8. make menuconfig -> added SAE J1939 support and debugging support for J1939 and CAN messages
9. make -j 3 deb-pkg LOCALVERSION=-custome

After an hour or so I am getting
Make[1]: *** [deb-pkg] error 2
Make: *** [deb-pkg] error 2

Git log for your reference
$ git log
commit b19a2567404ca81c321cbd21f58754217acee741
Merge: 32ac5b4 4d987c1
Author: Dinesh Velayudham <dinesh.velayutham@lnttechservices.com>
Date:   Thu Apr 7 15:15:38 2016 -0500
    Merge remote-tracking branch 'j1939/j1939d-v3.15'

commit 32ac5b4aae56cf9446c30463663c8ae2226069da
Author: Brad Figg <brad.figg@canonical.com>
Date:   Thu Mar 10 14:14:37 2016 -0800

    UBUNTU: Ubuntu-3.19.0-56.62
    Signed-off-by: Brad Figg <brad.figg@canonical.com>

commit 44047ff7e39e662a12fce97c8f817cd22e0d827f
Author: Florian Westphal <fw@strlen.de>
Date:   Thu Mar 10 17:26:39 2016 +0100
    UBUNTU: SAUCE: [nf,v2] netfilter: x_tables: don't rely on well-behaving usersp
    BugLink: http://bugs.launchpad.net/bugs/1555338


Regards
Dinesh Velayudham
L&T Technology Services
dinesh.velayutham@lnttechservices.com
+1-309-740-7691

-----Original Message-----
From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
Sent: Wednesday, April 06, 2016 2:40 PM
To: Dinesh Velayudham
Cc: linux-can@vger.kernel.org
Subject: Re: J1939 Linux

> Kurt,
> Thanks for the reply.
> After I post this question I got the github information, now that I am able to clone/merge from github.

I see.

>
> I am facing lot of merge conflicts.
> I am trying to merge Linux-J1939 to Linux kernel from Ubuntu - 3.19.0.56-generic.
> Which version of linux-j1939 would you suggest for easy merge? I tried
> v3.10, v.3.15 and v4.1

I suggest you merge branch j1939d-v3.15

Feel free to let me know if you experience merge conflicts with that branch. It's completely normal that you have merge conflicts with (most) other branches.

Kind regards,
Kurt
L&T Technology Services Ltd

www.LntTechservices.com<http://www.lnttechservices.com/>

This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

Re: J1939 Linux

[Kurt Van Dijck]

Hey,

> Kurt,
> I am facing deb-pkg error while building the kernel. Need your guidance on that.
> 
> Steps below.
> 1. I cloned the kernel from "http://kernel.ubuntu.com/git/kernel-ppa/mirror/ubuntu-vivid.git/commit/?id=32ac5b4aae56cf9446c30463663c8ae2226069da" with tag name "Ubuntu-3.19.0-56.62"
> 2. Then I added "git remote add j1939 git://github.com/kurt-vd/linux"
> 3. git remote update j1939
> 4. git merge j1939/j1939d-v3.15
> 5. Merge was successful without any issues.
> 6. cp /boot/config-3.19.0.56-generic .config
> 7. yes ' ' | make oldconfig
> 8. make menuconfig -> added SAE J1939 support and debugging support for J1939 and CAN messages
> 9. make -j 3 deb-pkg LOCALVERSION=-custome

I think you did everything well up to step 9.
My knowledge on building kernels specific for debian/Ubuntu  is limited.
Yet, the command you issue seems strange.
Shouldn't you just do:

	$ make -j 3 LOCALVERSION=-custome

and then

	$ sudo make install

Kind regards,
Kurt

Re: J1939 Linux

[gianluca]

On 04/08/2016 11:04 AM, Kurt Van Dijck wrote:
> Hey,
>
>> Kurt,
>> I am facing deb-pkg error while building the kernel. Need your guidance on that.
>>
>> Steps below.
>> 1. I cloned the kernel from "http://kernel.ubuntu.com/git/kernel-ppa/mirror/ubuntu-vivid.git/commit/?id=32ac5b4aae56cf9446c30463663c8ae2226069da" with tag name "Ubuntu-3.19.0-56.62"
>> 2. Then I added "git remote add j1939 git://github.com/kurt-vd/linux"
>> 3. git remote update j1939
>> 4. git merge j1939/j1939d-v3.15
>> 5. Merge was successful without any issues.
>> 6. cp /boot/config-3.19.0.56-generic .config
>> 7. yes ' ' | make oldconfig
>> 8. make menuconfig -> added SAE J1939 support and debugging support for J1939 and CAN messages
>> 9. make -j 3 deb-pkg LOCALVERSION=-custome
>
> I think you did everything well up to step 9.
> My knowledge on building kernels specific for debian/Ubuntu  is limited.
> Yet, the command you issue seems strange.
> Shouldn't you just do:
>
> 	$ make -j 3 LOCALVERSION=-custome
>
> and then
>
> 	$ sudo make install
>

Nope. Eventually you have to compile the drivers too with a make modules.

make deb-pkg will:

1. compile the kernel and the static drivers
2. compile the modules
3. install the modules
4. it will create the initrd for next boot.

> Kind regards,
> Kurt
> --
> To unsubscribe from this list: send the line "unsubscribe linux-can" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
>


-- 
Eurek s.r.l.                          |
Electronic Engineering                | http://www.eurek.it
via Celletta 8/B, 40026 Imola, Italy  | Phone: +39-(0)542-609120
p.iva 00690621206 - c.f. 04020030377  | Fax:   +39-(0)542-609212

Re: J1939 Linux

[Kurt Van Dijck]

On 8 April 2016 13:20:22 CEST, gianluca <gianlucarenzi@eurek.it> wrote:
>On 04/08/2016 11:04 AM, Kurt Van Dijck wrote:
>> Hey,
>>
>>> Kurt,
>>> I am facing deb-pkg error while building the kernel. Need your
>guidance on that.
>>>
>>> Steps below.
>>> 1. I cloned the kernel from
>"http://kernel.ubuntu.com/git/kernel-ppa/mirror/ubuntu-vivid.git/commit/?id=32ac5b4aae56cf9446c30463663c8ae2226069da"
>with tag name "Ubuntu-3.19.0-56.62"
>>> 2. Then I added "git remote add j1939
>git://github.com/kurt-vd/linux"
>>> 3. git remote update j1939
>>> 4. git merge j1939/j1939d-v3.15
>>> 5. Merge was successful without any issues.
>>> 6. cp /boot/config-3.19.0.56-generic .config
>>> 7. yes ' ' | make oldconfig
>>> 8. make menuconfig -> added SAE J1939 support and debugging support
>for J1939 and CAN messages
>>> 9. make -j 3 deb-pkg LOCALVERSION=-custome
>>
>> I think you did everything well up to step 9.
>> My knowledge on building kernels specific for debian/Ubuntu  is
>limited.
>> Yet, the command you issue seems strange.
>> Shouldn't you just do:
>>
>> 	$ make -j 3 LOCALVERSION=-custome
>>
>> and then
>>
>> 	$ sudo make install
>>
>
>Nope. Eventually you have to compile the drivers too with a make
>modules.

$ make modules_install
was what I forgot.

>
>make deb-pkg will:
>
>1. compile the kernel and the static drivers
>2. compile the modules
>3. install the modules
>4. it will create the initrd for next boot.

I see...
I will try this, but what is the chance this works on a Slackware?

Kurt
Sent from a small mobile device

RE: J1939 Linux

[Dinesh Velayudham]

Kurt and Eurek,
I did follow the same steps except that I did not enable J1939 option in menuconfig.
The build was successful and I am able to install the new custom kernel and reboot without any issues.
Looks like I am facing the problem only when I enable J1939 option under menuconfig.

Hope this helps you to narrow down the problem.


Regards
Dinesh Velayudham
L&T Technology Services
dinesh.velayutham@lnttechservices.com
+1-309-740-7691

-----Original Message-----
From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
Sent: Friday, April 08, 2016 6:59 AM
To: gianluca; Dinesh Velayudham; linux-can@vger.kernel.org
Subject: Re: J1939 Linux



On 8 April 2016 13:20:22 CEST, gianluca <gianlucarenzi@eurek.it> wrote:
>On 04/08/2016 11:04 AM, Kurt Van Dijck wrote:
>> Hey,
>>
>>> Kurt,
>>> I am facing deb-pkg error while building the kernel. Need your
>guidance on that.
>>>
>>> Steps below.
>>> 1. I cloned the kernel from
>"http://kernel.ubuntu.com/git/kernel-ppa/mirror/ubuntu-vivid.git/commit/?id=32ac5b4aae56cf9446c30463663c8ae2226069da"
>with tag name "Ubuntu-3.19.0-56.62"
>>> 2. Then I added "git remote add j1939
>git://github.com/kurt-vd/linux"
>>> 3. git remote update j1939
>>> 4. git merge j1939/j1939d-v3.15
>>> 5. Merge was successful without any issues.
>>> 6. cp /boot/config-3.19.0.56-generic .config 7. yes ' ' | make
>>> oldconfig 8. make menuconfig -> added SAE J1939 support and
>>> debugging support
>for J1939 and CAN messages
>>> 9. make -j 3 deb-pkg LOCALVERSION=-custome
>>
>> I think you did everything well up to step 9.
>> My knowledge on building kernels specific for debian/Ubuntu  is
>limited.
>> Yet, the command you issue seems strange.
>> Shouldn't you just do:
>>
>>      $ make -j 3 LOCALVERSION=-custome
>>
>> and then
>>
>>      $ sudo make install
>>
>
>Nope. Eventually you have to compile the drivers too with a make
>modules.

$ make modules_install
was what I forgot.

>
>make deb-pkg will:
>
>1. compile the kernel and the static drivers 2. compile the modules 3.
>install the modules 4. it will create the initrd for next boot.

I see...
I will try this, but what is the chance this works on a Slackware?

Kurt
Sent from a small mobile device
L&T Technology Services Ltd

www.LntTechservices.com<http://www.lnttechservices.com/>

This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

Re: J1939 Linux

[Kurt Van Dijck]

--- Original message ---
> Date: Fri, 8 Apr 2016 14:29:02 +0000
> From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, gianluca
>  <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
>  <linux-can@vger.kernel.org>
> Subject: RE: J1939 Linux
> 
> Kurt and Eurek,
> I did follow the same steps except that I did not enable J1939 option in menuconfig.
> The build was successful and I am able to install the new custom kernel and reboot without any issues.
> Looks like I am facing the problem only when I enable J1939 option under menuconfig.
> 
> Hope this helps you to narrow down the problem.

On my Slackware, I get as far as:

	INSTALL debian/headertmp/usr/include/linux/wimax/ (1 file)
	INSTALL debian/headertmp/usr/include/linux/ (420 files)
	INSTALL debian/headertmp/usr/include/asm/ (65 files)
	Using default distribution of 'unstable' in the changelog
	Install lsb-release or set $KDEB_CHANGELOG_DIST explicitly
	./scripts/package/builddeb: line 31: dpkg-gencontrol: command not found
	make[1]: *** [deb-pkg] Error 127
	make: *** [deb-pkg] Error 2

This is anyhow beyond my expertise. 
Since it clearly seems to be caused by my can-j1939, I will help to find
it. Can you show a bit more output where the build fails?
Possibly with V=2 commandline parameter?

Kurt

Re: J1939 Linux

[Kurt Van Dijck]

I apologise, I have given you the wrong commit to cherry-pick.
I gave the API change commit, and you need the one that adapts
it for can-j1939.
So forget the previous email (reset the git HEAD) and do

	git cherry-pick 34bb840

Kind regards,
Kurt

--- Original message ---
> Date: Tue, 12 Apr 2016 17:57:02 +0000
> From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
>  <linux-can@vger.kernel.org>
> Subject: RE: J1939 Linux
> 
> Kurt,
> I am still facing build error
> 1. cherry pick the code
> 2. make clean
> 3. make deb-pkg
> 
> $ git cherry-pick 7eab8d9e
> [master bf6fe85] new helper: memcpy_to_msg()
>  Author: Al Viro <viro@zeniv.linux.org.uk>
>  1 file changed, 5 insertions(+)
> 
> $ make clean
>   CLEAN   .
>   CLEAN   arch/x86/kernel/cpu
>   CLEAN   arch/x86/kernel
>   CLEAN   arch/x86/purgatory
>   CLEAN   arch/x86/realmode/rm
>   CLEAN   arch/x86/vdso
>   CLEAN   arch/x86/lib
>   CLEAN   crypto/asymmetric_keys
>   CLEAN   drivers/gpu/drm/radeon
>   CLEAN   drivers/net/wan
>   CLEAN   drivers/scsi/aic7xxx
>   CLEAN   drivers/tty/vt
>   CLEAN   firmware
>   CLEAN   kernel/debug/kdb
>   CLEAN   kernel/time
>   CLEAN   kernel
>   CLEAN   lib/raid6
>   CLEAN   lib
>   CLEAN   security/apparmor
>   CLEAN   security/selinux
>   CLEAN   usr
>   CLEAN   arch/x86/boot/compressed
>   CLEAN   arch/x86/boot
>   CLEAN   arch/x86/tools
>   CLEAN   .tmp_versions
> 
> $ make -j 4 V=2 deb-pkg LOCALVERSION=-custom 2>&1 | tee buildlog.txt
>  In file included from include/crypto/algapi.h:18:0,
>                  from include/crypto/internal/hash.h:16,
>                  from arch/x86/crypto/crc32c-intel_glue.c:31:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of ‘memcpy_to_msg’ was here
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[4]: *** [arch/x86/crypto/crc32c-intel_glue.o] Error 1
> make[3]: *** [arch/x86/crypto] Error 2
> make[3]: *** Waiting for unfinished jobs....
>   CC      kernel/exec_domain.o - due to target missing
>   CC      arch/x86/ia32/ia32_signal.o - due to target missing
>   CC      init/do_mounts.o - due to target missing
> In file included from include/linux/netfilter.h:5:0,
>                  from include/net/netns/netfilter.h:5,
>                  from include/net/net_namespace.h:22,
>                  from include/linux/init_task.h:15,
>                  from kernel/fork.c:534:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of ‘memcpy_to_msg’ was here
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[3]: *** [kernel/fork.o] Error 1
> make[2]: *** [kernel] Error 2
> make[2]: *** Waiting for unfinished jobs....
>   CC      init/do_mounts_rd.o - due to target missing
>   CC      arch/x86/ia32/nosyscall.o - due to target missing
>   CC      arch/x86/ia32/syscall_ia32.o - due to target missing
>   CC      init/do_mounts_initrd.o - due to target missing
>   CC      arch/x86/ia32/audit.o - due to target missing
>   LD      arch/x86/ia32/built-in.o - due to target missing
> make[2]: *** [arch/x86] Error 2
>   CC      init/do_mounts_md.o - due to target missing
> In file included from include/linux/icmpv6.h:4:0,
>                  from include/linux/ipv6.h:63,
>                  from include/net/ipv6.h:16,
>                  from include/linux/sunrpc/clnt.h:27,
>                  from include/linux/nfs_fs.h:30,
>                  from init/do_mounts.c:32:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of ‘memcpy_to_msg’ was here
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
>   CC      init/initramfs.o - due to target missing
>   CC      init/calibrate.o - due to target missing
>   CC      init/init_task.o - due to target missing
>   CC      init/version.o - due to target missing
> cc1: some warnings being treated as errors
> make[3]: *** [init/do_mounts.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> In file included from include/linux/netfilter.h:5:0,
>                  from include/net/netns/netfilter.h:5,
>                  from include/net/net_namespace.h:22,
>                  from include/linux/init_task.h:15,
>                  from init/init_task.c:1:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of ‘memcpy_to_msg’ was here
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[3]: *** [init/init_task.o] Error 1
> make[2]: *** [init] Error 2
> make[1]: *** [deb-pkg] Error 2
> make: *** [deb-pkg] Error 2
> 
> 
> Regards
> Dinesh Velayudham
> L&T Technology Services
> dinesh.velayutham@lnttechservices.com
> +1-309-740-7691
> 
> -----Original Message-----
> From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> Sent: Tuesday, April 12, 2016 3:20 AM
> To: Dinesh Velayudham
> Cc: gianluca; linux-can@vger.kernel.org
> Subject: Re: J1939 Linux
> 
> Ok, I see.
> It had nothing to do with "make deb-pkg", it is a problem
> that I didn't see that commit 7eab8d9e is necessary as of v3.19, where I
> only saw that v4.1 needed it.
> 
> Please do:
> 
>         $ git cherry-pick 7eab8d9e
> 
> and the make should succeed.
> 
> Sorry for not seeing this. I will try to prepare a j1939d-v3.19 branch,
> which will have that commit included.
> 
> Kind regards,
> Kurt
> 
> --- Original message ---
> > Date: Mon, 11 Apr 2016 22:11:11 +0000
> > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> > CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> >  <linux-can@vger.kernel.org>
> > Subject: RE: J1939 Linux
> >
> > Kurt,
> > I have attached text file that contains output of make command with V=2. Incase if you are not able to see the attached text file. Below is part of make command output
> > -------------------------------------
> >   CC      lib/strncpy_from_user.o - due to target missing
> >   CC [M]  net/can/j1939/socket.o - due to target missing
> >   CC      lib/strnlen_user.o - due to target missing
> > net/can/j1939/socket.c: In function ‘j1939sk_recvmsg’:
> > net/can/j1939/socket.c:621:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> >   ^
> > net/can/j1939/socket.c:621:26: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> >                           ^
> > net/can/j1939/socket.c: In function ‘j1939sk_sendmsg’:
> > net/can/j1939/socket.c:708:48: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   ret = memcpy_fromiovec(skb_put(skb, size), msg->msg_iov, size);
> >                                                 ^
> > cc1: some warnings being treated as errors
> >   CC      lib/net_utils.o - due to target missing
> > make[5]: *** [net/can/j1939/socket.o] Error 1
> > make[4]: *** [net/can/j1939] Error 2
> > make[3]: *** [net/can] Error 2
> > make[2]: *** [net] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >
> > ---------------------------------------------------
> >
> > Regards
> > Dinesh Velayudham
> > L&T Technology Services
> > dinesh.velayutham@lnttechservices.com
> > +1-309-740-7691
> >
> > -----Original Message-----
> > From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> > Sent: Saturday, April 09, 2016 6:40 AM
> > To: Dinesh Velayudham
> > Cc: gianluca; linux-can@vger.kernel.org
> > Subject: Re: J1939 Linux
> >
> >
> > --- Original message ---
> > > Date: Fri, 8 Apr 2016 14:29:02 +0000
> > > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, gianluca
> > > <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> > >  <linux-can@vger.kernel.org>
> > > Subject: RE: J1939 Linux
> > >
> > > Kurt and Eurek,
> > > I did follow the same steps except that I did not enable J1939 option in menuconfig.
> > > The build was successful and I am able to install the new custom kernel and reboot without any issues.
> > > Looks like I am facing the problem only when I enable J1939 option under menuconfig.
> > >
> > > Hope this helps you to narrow down the problem.
> >
> > On my Slackware, I get as far as:
> >
> >         INSTALL debian/headertmp/usr/include/linux/wimax/ (1 file)
> >         INSTALL debian/headertmp/usr/include/linux/ (420 files)
> >         INSTALL debian/headertmp/usr/include/asm/ (65 files)
> >         Using default distribution of 'unstable' in the changelog
> >         Install lsb-release or set $KDEB_CHANGELOG_DIST explicitly
> >         ./scripts/package/builddeb: line 31: dpkg-gencontrol: command not found
> >         make[1]: *** [deb-pkg] Error 127
> >         make: *** [deb-pkg] Error 2
> >
> > This is anyhow beyond my expertise.
> > Since it clearly seems to be caused by my can-j1939, I will help to find it. Can you show a bit more output where the build fails?
> > Possibly with V=2 commandline parameter?
> >
> > Kurt
> > L&T Technology Services Ltd
> >
> > www.LntTechservices.com<http://www.lnttechservices.com/>
> >
> > This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.
> 

RE: J1939 Linux

[Dinesh Velayudham]

I don’t think this will work as the cherry-pick only changes the socket.c file. The " memcpy_toiovec" has been used in few more places e.g /include/linux/skbuff.h,


Regards
Dinesh Velayudham
L&T Technology Services
dinesh.velayutham@lnttechservices.com
+1-309-740-7691

-----Original Message-----
From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
Sent: Tuesday, April 12, 2016 1:16 PM
To: Dinesh Velayudham
Cc: gianluca; linux-can@vger.kernel.org
Subject: Re: J1939 Linux

I apologise, I have given you the wrong commit to cherry-pick.
I gave the API change commit, and you need the one that adapts it for can-j1939.
So forget the previous email (reset the git HEAD) and do

        git cherry-pick 34bb840

Kind regards,
Kurt

--- Original message ---
> Date: Tue, 12 Apr 2016 17:57:02 +0000
> From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
>  <linux-can@vger.kernel.org>
> Subject: RE: J1939 Linux
>
> Kurt,
> I am still facing build error
> 1. cherry pick the code
> 2. make clean
> 3. make deb-pkg
>
> $ git cherry-pick 7eab8d9e
> [master bf6fe85] new helper: memcpy_to_msg()
>  Author: Al Viro <viro@zeniv.linux.org.uk>
>  1 file changed, 5 insertions(+)
>
> $ make clean
>   CLEAN   .
>   CLEAN   arch/x86/kernel/cpu
>   CLEAN   arch/x86/kernel
>   CLEAN   arch/x86/purgatory
>   CLEAN   arch/x86/realmode/rm
>   CLEAN   arch/x86/vdso
>   CLEAN   arch/x86/lib
>   CLEAN   crypto/asymmetric_keys
>   CLEAN   drivers/gpu/drm/radeon
>   CLEAN   drivers/net/wan
>   CLEAN   drivers/scsi/aic7xxx
>   CLEAN   drivers/tty/vt
>   CLEAN   firmware
>   CLEAN   kernel/debug/kdb
>   CLEAN   kernel/time
>   CLEAN   kernel
>   CLEAN   lib/raid6
>   CLEAN   lib
>   CLEAN   security/apparmor
>   CLEAN   security/selinux
>   CLEAN   usr
>   CLEAN   arch/x86/boot/compressed
>   CLEAN   arch/x86/boot
>   CLEAN   arch/x86/tools
>   CLEAN   .tmp_versions
>
> $ make -j 4 V=2 deb-pkg LOCALVERSION=-custom 2>&1 | tee buildlog.txt
> In file included from include/crypto/algapi.h:18:0,
>                  from include/crypto/internal/hash.h:16,
>                  from arch/x86/crypto/crc32c-intel_glue.c:31:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of
> ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[4]: *** [arch/x86/crypto/crc32c-intel_glue.o] Error 1
> make[3]: *** [arch/x86/crypto] Error 2
> make[3]: *** Waiting for unfinished jobs....
>   CC      kernel/exec_domain.o - due to target missing
>   CC      arch/x86/ia32/ia32_signal.o - due to target missing
>   CC      init/do_mounts.o - due to target missing
> In file included from include/linux/netfilter.h:5:0,
>                  from include/net/netns/netfilter.h:5,
>                  from include/net/net_namespace.h:22,
>                  from include/linux/init_task.h:15,
>                  from kernel/fork.c:534:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of
> ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[3]: *** [kernel/fork.o] Error 1
> make[2]: *** [kernel] Error 2
> make[2]: *** Waiting for unfinished jobs....
>   CC      init/do_mounts_rd.o - due to target missing
>   CC      arch/x86/ia32/nosyscall.o - due to target missing
>   CC      arch/x86/ia32/syscall_ia32.o - due to target missing
>   CC      init/do_mounts_initrd.o - due to target missing
>   CC      arch/x86/ia32/audit.o - due to target missing
>   LD      arch/x86/ia32/built-in.o - due to target missing
> make[2]: *** [arch/x86] Error 2
>   CC      init/do_mounts_md.o - due to target missing
> In file included from include/linux/icmpv6.h:4:0,
>                  from include/linux/ipv6.h:63,
>                  from include/net/ipv6.h:16,
>                  from include/linux/sunrpc/clnt.h:27,
>                  from include/linux/nfs_fs.h:30,
>                  from init/do_mounts.c:32:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of
> ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
>   CC      init/initramfs.o - due to target missing
>   CC      init/calibrate.o - due to target missing
>   CC      init/init_task.o - due to target missing
>   CC      init/version.o - due to target missing
> cc1: some warnings being treated as errors
> make[3]: *** [init/do_mounts.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> In file included from include/linux/netfilter.h:5:0,
>                  from include/net/netns/netfilter.h:5,
>                  from include/net/net_namespace.h:22,
>                  from include/linux/init_task.h:15,
>                  from init/init_task.c:1:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of
> ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[3]: *** [init/init_task.o] Error 1
> make[2]: *** [init] Error 2
> make[1]: *** [deb-pkg] Error 2
> make: *** [deb-pkg] Error 2
>
>
> Regards
> Dinesh Velayudham
> L&T Technology Services
> dinesh.velayutham@lnttechservices.com
> +1-309-740-7691
>
> -----Original Message-----
> From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> Sent: Tuesday, April 12, 2016 3:20 AM
> To: Dinesh Velayudham
> Cc: gianluca; linux-can@vger.kernel.org
> Subject: Re: J1939 Linux
>
> Ok, I see.
> It had nothing to do with "make deb-pkg", it is a problem that I
> didn't see that commit 7eab8d9e is necessary as of v3.19, where I only
> saw that v4.1 needed it.
>
> Please do:
>
>         $ git cherry-pick 7eab8d9e
>
> and the make should succeed.
>
> Sorry for not seeing this. I will try to prepare a j1939d-v3.19
> branch, which will have that commit included.
>
> Kind regards,
> Kurt
>
> --- Original message ---
> > Date: Mon, 11 Apr 2016 22:11:11 +0000
> > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> > CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> >  <linux-can@vger.kernel.org>
> > Subject: RE: J1939 Linux
> >
> > Kurt,
> > I have attached text file that contains output of make command with
> > V=2. Incase if you are not able to see the attached text file. Below
> > is part of make command output
> > -------------------------------------
> >   CC      lib/strncpy_from_user.o - due to target missing
> >   CC [M]  net/can/j1939/socket.o - due to target missing
> >   CC      lib/strnlen_user.o - due to target missing
> > net/can/j1939/socket.c: In function ‘j1939sk_recvmsg’:
> > net/can/j1939/socket.c:621:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> >   ^
> > net/can/j1939/socket.c:621:26: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> >                           ^
> > net/can/j1939/socket.c: In function ‘j1939sk_sendmsg’:
> > net/can/j1939/socket.c:708:48: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   ret = memcpy_fromiovec(skb_put(skb, size), msg->msg_iov, size);
> >                                                 ^
> > cc1: some warnings being treated as errors
> >   CC      lib/net_utils.o - due to target missing
> > make[5]: *** [net/can/j1939/socket.o] Error 1
> > make[4]: *** [net/can/j1939] Error 2
> > make[3]: *** [net/can] Error 2
> > make[2]: *** [net] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >
> > ---------------------------------------------------
> >
> > Regards
> > Dinesh Velayudham
> > L&T Technology Services
> > dinesh.velayutham@lnttechservices.com
> > +1-309-740-7691
> >
> > -----Original Message-----
> > From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> > Sent: Saturday, April 09, 2016 6:40 AM
> > To: Dinesh Velayudham
> > Cc: gianluca; linux-can@vger.kernel.org
> > Subject: Re: J1939 Linux
> >
> >
> > --- Original message ---
> > > Date: Fri, 8 Apr 2016 14:29:02 +0000
> > > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, gianluca
> > > <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> > >  <linux-can@vger.kernel.org>
> > > Subject: RE: J1939 Linux
> > >
> > > Kurt and Eurek,
> > > I did follow the same steps except that I did not enable J1939 option in menuconfig.
> > > The build was successful and I am able to install the new custom kernel and reboot without any issues.
> > > Looks like I am facing the problem only when I enable J1939 option under menuconfig.
> > >
> > > Hope this helps you to narrow down the problem.
> >
> > On my Slackware, I get as far as:
> >
> >         INSTALL debian/headertmp/usr/include/linux/wimax/ (1 file)
> >         INSTALL debian/headertmp/usr/include/linux/ (420 files)
> >         INSTALL debian/headertmp/usr/include/asm/ (65 files)
> >         Using default distribution of 'unstable' in the changelog
> >         Install lsb-release or set $KDEB_CHANGELOG_DIST explicitly
> >         ./scripts/package/builddeb: line 31: dpkg-gencontrol: command not found
> >         make[1]: *** [deb-pkg] Error 127
> >         make: *** [deb-pkg] Error 2
> >
> > This is anyhow beyond my expertise.
> > Since it clearly seems to be caused by my can-j1939, I will help to find it. Can you show a bit more output where the build fails?
> > Possibly with V=2 commandline parameter?
> >
> > Kurt
> > L&T Technology Services Ltd
> >
> > www.LntTechservices.com<http://www.lnttechservices.com/>
> >
> > This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.
>
L&T Technology Services Ltd

www.LntTechservices.com<http://www.lnttechservices.com/>

This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

RE: J1939 Linux

[Dinesh Velayudham]

Kurt,
Do you have v3.19 for me to build and test?


Regards
Dinesh Velayudham
L&T Technology Services
dinesh.velayutham@lnttechservices.com
+1-309-740-7691

-----Original Message-----
From: Dinesh Velayudham
Sent: Tuesday, April 12, 2016 1:28 PM
To: 'Kurt Van Dijck'
Cc: gianluca; linux-can@vger.kernel.org
Subject: RE: J1939 Linux

I don’t think this will work as the cherry-pick only changes the socket.c file. The " memcpy_toiovec" has been used in few more places e.g /include/linux/skbuff.h,


Regards
Dinesh Velayudham
L&T Technology Services
dinesh.velayutham@lnttechservices.com
+1-309-740-7691

-----Original Message-----
From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
Sent: Tuesday, April 12, 2016 1:16 PM
To: Dinesh Velayudham
Cc: gianluca; linux-can@vger.kernel.org
Subject: Re: J1939 Linux

I apologise, I have given you the wrong commit to cherry-pick.
I gave the API change commit, and you need the one that adapts it for can-j1939.
So forget the previous email (reset the git HEAD) and do

        git cherry-pick 34bb840

Kind regards,
Kurt

--- Original message ---
> Date: Tue, 12 Apr 2016 17:57:02 +0000
> From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
>  <linux-can@vger.kernel.org>
> Subject: RE: J1939 Linux
>
> Kurt,
> I am still facing build error
> 1. cherry pick the code
> 2. make clean
> 3. make deb-pkg
>
> $ git cherry-pick 7eab8d9e
> [master bf6fe85] new helper: memcpy_to_msg()
>  Author: Al Viro <viro@zeniv.linux.org.uk>
>  1 file changed, 5 insertions(+)
>
> $ make clean
>   CLEAN   .
>   CLEAN   arch/x86/kernel/cpu
>   CLEAN   arch/x86/kernel
>   CLEAN   arch/x86/purgatory
>   CLEAN   arch/x86/realmode/rm
>   CLEAN   arch/x86/vdso
>   CLEAN   arch/x86/lib
>   CLEAN   crypto/asymmetric_keys
>   CLEAN   drivers/gpu/drm/radeon
>   CLEAN   drivers/net/wan
>   CLEAN   drivers/scsi/aic7xxx
>   CLEAN   drivers/tty/vt
>   CLEAN   firmware
>   CLEAN   kernel/debug/kdb
>   CLEAN   kernel/time
>   CLEAN   kernel
>   CLEAN   lib/raid6
>   CLEAN   lib
>   CLEAN   security/apparmor
>   CLEAN   security/selinux
>   CLEAN   usr
>   CLEAN   arch/x86/boot/compressed
>   CLEAN   arch/x86/boot
>   CLEAN   arch/x86/tools
>   CLEAN   .tmp_versions
>
> $ make -j 4 V=2 deb-pkg LOCALVERSION=-custom 2>&1 | tee buildlog.txt
> In file included from include/crypto/algapi.h:18:0,
>                  from include/crypto/internal/hash.h:16,
>                  from arch/x86/crypto/crc32c-intel_glue.c:31:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of
> ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[4]: *** [arch/x86/crypto/crc32c-intel_glue.o] Error 1
> make[3]: *** [arch/x86/crypto] Error 2
> make[3]: *** Waiting for unfinished jobs....
>   CC      kernel/exec_domain.o - due to target missing
>   CC      arch/x86/ia32/ia32_signal.o - due to target missing
>   CC      init/do_mounts.o - due to target missing
> In file included from include/linux/netfilter.h:5:0,
>                  from include/net/netns/netfilter.h:5,
>                  from include/net/net_namespace.h:22,
>                  from include/linux/init_task.h:15,
>                  from kernel/fork.c:534:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of
> ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[3]: *** [kernel/fork.o] Error 1
> make[2]: *** [kernel] Error 2
> make[2]: *** Waiting for unfinished jobs....
>   CC      init/do_mounts_rd.o - due to target missing
>   CC      arch/x86/ia32/nosyscall.o - due to target missing
>   CC      arch/x86/ia32/syscall_ia32.o - due to target missing
>   CC      init/do_mounts_initrd.o - due to target missing
>   CC      arch/x86/ia32/audit.o - due to target missing
>   LD      arch/x86/ia32/built-in.o - due to target missing
> make[2]: *** [arch/x86] Error 2
>   CC      init/do_mounts_md.o - due to target missing
> In file included from include/linux/icmpv6.h:4:0,
>                  from include/linux/ipv6.h:63,
>                  from include/net/ipv6.h:16,
>                  from include/linux/sunrpc/clnt.h:27,
>                  from include/linux/nfs_fs.h:30,
>                  from init/do_mounts.c:32:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of
> ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
>   CC      init/initramfs.o - due to target missing
>   CC      init/calibrate.o - due to target missing
>   CC      init/init_task.o - due to target missing
>   CC      init/version.o - due to target missing
> cc1: some warnings being treated as errors
> make[3]: *** [init/do_mounts.o] Error 1
> make[3]: *** Waiting for unfinished jobs....
> In file included from include/linux/netfilter.h:5:0,
>                  from include/net/netns/netfilter.h:5,
>                  from include/net/net_namespace.h:22,
>                  from include/linux/init_task.h:15,
>                  from init/init_task.c:1:
> include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
>  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h:2705:19: note: previous definition of
> ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
>                    ^
> include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
>   return memcpy_toiovec(msg->msg_iov, data, len);
>   ^
> include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
>   return memcpy_toiovec(msg->msg_iov, data, len);
>                            ^
> cc1: some warnings being treated as errors
> make[3]: *** [init/init_task.o] Error 1
> make[2]: *** [init] Error 2
> make[1]: *** [deb-pkg] Error 2
> make: *** [deb-pkg] Error 2
>
>
> Regards
> Dinesh Velayudham
> L&T Technology Services
> dinesh.velayutham@lnttechservices.com
> +1-309-740-7691
>
> -----Original Message-----
> From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> Sent: Tuesday, April 12, 2016 3:20 AM
> To: Dinesh Velayudham
> Cc: gianluca; linux-can@vger.kernel.org
> Subject: Re: J1939 Linux
>
> Ok, I see.
> It had nothing to do with "make deb-pkg", it is a problem that I
> didn't see that commit 7eab8d9e is necessary as of v3.19, where I only
> saw that v4.1 needed it.
>
> Please do:
>
>         $ git cherry-pick 7eab8d9e
>
> and the make should succeed.
>
> Sorry for not seeing this. I will try to prepare a j1939d-v3.19
> branch, which will have that commit included.
>
> Kind regards,
> Kurt
>
> --- Original message ---
> > Date: Mon, 11 Apr 2016 22:11:11 +0000
> > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> > CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> >  <linux-can@vger.kernel.org>
> > Subject: RE: J1939 Linux
> >
> > Kurt,
> > I have attached text file that contains output of make command with
> > V=2. Incase if you are not able to see the attached text file. Below
> > is part of make command output
> > -------------------------------------
> >   CC      lib/strncpy_from_user.o - due to target missing
> >   CC [M]  net/can/j1939/socket.o - due to target missing
> >   CC      lib/strnlen_user.o - due to target missing
> > net/can/j1939/socket.c: In function ‘j1939sk_recvmsg’:
> > net/can/j1939/socket.c:621:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> >   ^
> > net/can/j1939/socket.c:621:26: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> >                           ^
> > net/can/j1939/socket.c: In function ‘j1939sk_sendmsg’:
> > net/can/j1939/socket.c:708:48: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   ret = memcpy_fromiovec(skb_put(skb, size), msg->msg_iov, size);
> >                                                 ^
> > cc1: some warnings being treated as errors
> >   CC      lib/net_utils.o - due to target missing
> > make[5]: *** [net/can/j1939/socket.o] Error 1
> > make[4]: *** [net/can/j1939] Error 2
> > make[3]: *** [net/can] Error 2
> > make[2]: *** [net] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >
> > ---------------------------------------------------
> >
> > Regards
> > Dinesh Velayudham
> > L&T Technology Services
> > dinesh.velayutham@lnttechservices.com
> > +1-309-740-7691
> >
> > -----Original Message-----
> > From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> > Sent: Saturday, April 09, 2016 6:40 AM
> > To: Dinesh Velayudham
> > Cc: gianluca; linux-can@vger.kernel.org
> > Subject: Re: J1939 Linux
> >
> >
> > --- Original message ---
> > > Date: Fri, 8 Apr 2016 14:29:02 +0000
> > > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, gianluca
> > > <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> > >  <linux-can@vger.kernel.org>
> > > Subject: RE: J1939 Linux
> > >
> > > Kurt and Eurek,
> > > I did follow the same steps except that I did not enable J1939 option in menuconfig.
> > > The build was successful and I am able to install the new custom kernel and reboot without any issues.
> > > Looks like I am facing the problem only when I enable J1939 option under menuconfig.
> > >
> > > Hope this helps you to narrow down the problem.
> >
> > On my Slackware, I get as far as:
> >
> >         INSTALL debian/headertmp/usr/include/linux/wimax/ (1 file)
> >         INSTALL debian/headertmp/usr/include/linux/ (420 files)
> >         INSTALL debian/headertmp/usr/include/asm/ (65 files)
> >         Using default distribution of 'unstable' in the changelog
> >         Install lsb-release or set $KDEB_CHANGELOG_DIST explicitly
> >         ./scripts/package/builddeb: line 31: dpkg-gencontrol: command not found
> >         make[1]: *** [deb-pkg] Error 127
> >         make: *** [deb-pkg] Error 2
> >
> > This is anyhow beyond my expertise.
> > Since it clearly seems to be caused by my can-j1939, I will help to find it. Can you show a bit more output where the build fails?
> > Possibly with V=2 commandline parameter?
> >
> > Kurt
> > L&T Technology Services Ltd
> >
> > www.LntTechservices.com<http://www.lnttechservices.com/>
> >
> > This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.
>
L&T Technology Services Ltd

www.LntTechservices.com<http://www.lnttechservices.com/>

This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

Re: J1939 Linux

[Kurt Van Dijck]

Hi,

> Kurt,
> Do you have v3.19 for me to build and test?

I did have the intention, but I couldn't find an available timeslot
today. I'm sure I can do tomorrow.

Kurt

Re: J1939 Linux

[Kurt Van Dijck]

I pushed j1939d-v3.19.

I created the branch by merging & cherry-pick, as suggested earlier.
I didn't have compile problems.

I have not tested it, yet I foresee no problems, or at least no
differences compared to my other j1939d-vx.xx branches.

Kind regards,
Kurt

--- Original message ---
> Date: Wed, 13 Apr 2016 16:08:33 +0000
> From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
>  <linux-can@vger.kernel.org>
> Subject: RE: J1939 Linux
> 
> Kurt,
> Do you have v3.19 for me to build and test?
> 
> 
> Regards
> Dinesh Velayudham
> L&T Technology Services
> dinesh.velayutham@lnttechservices.com
> +1-309-740-7691
> 
> -----Original Message-----
> From: Dinesh Velayudham
> Sent: Tuesday, April 12, 2016 1:28 PM
> To: 'Kurt Van Dijck'
> Cc: gianluca; linux-can@vger.kernel.org
> Subject: RE: J1939 Linux
> 
> I don’t think this will work as the cherry-pick only changes the socket.c file. The " memcpy_toiovec" has been used in few more places e.g /include/linux/skbuff.h,
> 
> 
> Regards
> Dinesh Velayudham
> L&T Technology Services
> dinesh.velayutham@lnttechservices.com
> +1-309-740-7691
> 
> -----Original Message-----
> From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> Sent: Tuesday, April 12, 2016 1:16 PM
> To: Dinesh Velayudham
> Cc: gianluca; linux-can@vger.kernel.org
> Subject: Re: J1939 Linux
> 
> I apologise, I have given you the wrong commit to cherry-pick.
> I gave the API change commit, and you need the one that adapts it for can-j1939.
> So forget the previous email (reset the git HEAD) and do
> 
>         git cherry-pick 34bb840
> 
> Kind regards,
> Kurt
> 
> --- Original message ---
> > Date: Tue, 12 Apr 2016 17:57:02 +0000
> > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> > CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> >  <linux-can@vger.kernel.org>
> > Subject: RE: J1939 Linux
> >
> > Kurt,
> > I am still facing build error
> > 1. cherry pick the code
> > 2. make clean
> > 3. make deb-pkg
> >
> > $ git cherry-pick 7eab8d9e
> > [master bf6fe85] new helper: memcpy_to_msg()
> >  Author: Al Viro <viro@zeniv.linux.org.uk>
> >  1 file changed, 5 insertions(+)
> >
> > $ make clean
> >   CLEAN   .
> >   CLEAN   arch/x86/kernel/cpu
> >   CLEAN   arch/x86/kernel
> >   CLEAN   arch/x86/purgatory
> >   CLEAN   arch/x86/realmode/rm
> >   CLEAN   arch/x86/vdso
> >   CLEAN   arch/x86/lib
> >   CLEAN   crypto/asymmetric_keys
> >   CLEAN   drivers/gpu/drm/radeon
> >   CLEAN   drivers/net/wan
> >   CLEAN   drivers/scsi/aic7xxx
> >   CLEAN   drivers/tty/vt
> >   CLEAN   firmware
> >   CLEAN   kernel/debug/kdb
> >   CLEAN   kernel/time
> >   CLEAN   kernel
> >   CLEAN   lib/raid6
> >   CLEAN   lib
> >   CLEAN   security/apparmor
> >   CLEAN   security/selinux
> >   CLEAN   usr
> >   CLEAN   arch/x86/boot/compressed
> >   CLEAN   arch/x86/boot
> >   CLEAN   arch/x86/tools
> >   CLEAN   .tmp_versions
> >
> > $ make -j 4 V=2 deb-pkg LOCALVERSION=-custom 2>&1 | tee buildlog.txt
> > In file included from include/crypto/algapi.h:18:0,
> >                  from include/crypto/internal/hash.h:16,
> >                  from arch/x86/crypto/crc32c-intel_glue.c:31:
> > include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
> >  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h:2705:19: note: previous definition of
> > ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> > include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >   ^
> > include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >                            ^
> > cc1: some warnings being treated as errors
> > make[4]: *** [arch/x86/crypto/crc32c-intel_glue.o] Error 1
> > make[3]: *** [arch/x86/crypto] Error 2
> > make[3]: *** Waiting for unfinished jobs....
> >   CC      kernel/exec_domain.o - due to target missing
> >   CC      arch/x86/ia32/ia32_signal.o - due to target missing
> >   CC      init/do_mounts.o - due to target missing
> > In file included from include/linux/netfilter.h:5:0,
> >                  from include/net/netns/netfilter.h:5,
> >                  from include/net/net_namespace.h:22,
> >                  from include/linux/init_task.h:15,
> >                  from kernel/fork.c:534:
> > include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
> >  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h:2705:19: note: previous definition of
> > ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> > include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >   ^
> > include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >                            ^
> > cc1: some warnings being treated as errors
> > make[3]: *** [kernel/fork.o] Error 1
> > make[2]: *** [kernel] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >   CC      init/do_mounts_rd.o - due to target missing
> >   CC      arch/x86/ia32/nosyscall.o - due to target missing
> >   CC      arch/x86/ia32/syscall_ia32.o - due to target missing
> >   CC      init/do_mounts_initrd.o - due to target missing
> >   CC      arch/x86/ia32/audit.o - due to target missing
> >   LD      arch/x86/ia32/built-in.o - due to target missing
> > make[2]: *** [arch/x86] Error 2
> >   CC      init/do_mounts_md.o - due to target missing
> > In file included from include/linux/icmpv6.h:4:0,
> >                  from include/linux/ipv6.h:63,
> >                  from include/net/ipv6.h:16,
> >                  from include/linux/sunrpc/clnt.h:27,
> >                  from include/linux/nfs_fs.h:30,
> >                  from init/do_mounts.c:32:
> > include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
> >  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h:2705:19: note: previous definition of
> > ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> > include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >   ^
> > include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >                            ^
> >   CC      init/initramfs.o - due to target missing
> >   CC      init/calibrate.o - due to target missing
> >   CC      init/init_task.o - due to target missing
> >   CC      init/version.o - due to target missing
> > cc1: some warnings being treated as errors
> > make[3]: *** [init/do_mounts.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > In file included from include/linux/netfilter.h:5:0,
> >                  from include/net/netns/netfilter.h:5,
> >                  from include/net/net_namespace.h:22,
> >                  from include/linux/init_task.h:15,
> >                  from init/init_task.c:1:
> > include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
> >  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h:2705:19: note: previous definition of
> > ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> > include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >   ^
> > include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >                            ^
> > cc1: some warnings being treated as errors
> > make[3]: *** [init/init_task.o] Error 1
> > make[2]: *** [init] Error 2
> > make[1]: *** [deb-pkg] Error 2
> > make: *** [deb-pkg] Error 2
> >
> >
> > Regards
> > Dinesh Velayudham
> > L&T Technology Services
> > dinesh.velayutham@lnttechservices.com
> > +1-309-740-7691
> >
> > -----Original Message-----
> > From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> > Sent: Tuesday, April 12, 2016 3:20 AM
> > To: Dinesh Velayudham
> > Cc: gianluca; linux-can@vger.kernel.org
> > Subject: Re: J1939 Linux
> >
> > Ok, I see.
> > It had nothing to do with "make deb-pkg", it is a problem that I
> > didn't see that commit 7eab8d9e is necessary as of v3.19, where I only
> > saw that v4.1 needed it.
> >
> > Please do:
> >
> >         $ git cherry-pick 7eab8d9e
> >
> > and the make should succeed.
> >
> > Sorry for not seeing this. I will try to prepare a j1939d-v3.19
> > branch, which will have that commit included.
> >
> > Kind regards,
> > Kurt
> >
> > --- Original message ---
> > > Date: Mon, 11 Apr 2016 22:11:11 +0000
> > > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> > > CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> > >  <linux-can@vger.kernel.org>
> > > Subject: RE: J1939 Linux
> > >
> > > Kurt,
> > > I have attached text file that contains output of make command with
> > > V=2. Incase if you are not able to see the attached text file. Below
> > > is part of make command output
> > > -------------------------------------
> > >   CC      lib/strncpy_from_user.o - due to target missing
> > >   CC [M]  net/can/j1939/socket.o - due to target missing
> > >   CC      lib/strnlen_user.o - due to target missing
> > > net/can/j1939/socket.c: In function ‘j1939sk_recvmsg’:
> > > net/can/j1939/socket.c:621:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> > >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> > >   ^
> > > net/can/j1939/socket.c:621:26: error: ‘struct msghdr’ has no member named ‘msg_iov’
> > >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> > >                           ^
> > > net/can/j1939/socket.c: In function ‘j1939sk_sendmsg’:
> > > net/can/j1939/socket.c:708:48: error: ‘struct msghdr’ has no member named ‘msg_iov’
> > >   ret = memcpy_fromiovec(skb_put(skb, size), msg->msg_iov, size);
> > >                                                 ^
> > > cc1: some warnings being treated as errors
> > >   CC      lib/net_utils.o - due to target missing
> > > make[5]: *** [net/can/j1939/socket.o] Error 1
> > > make[4]: *** [net/can/j1939] Error 2
> > > make[3]: *** [net/can] Error 2
> > > make[2]: *** [net] Error 2
> > > make[2]: *** Waiting for unfinished jobs....
> > >
> > > ---------------------------------------------------
> > >
> > > Regards
> > > Dinesh Velayudham
> > > L&T Technology Services
> > > dinesh.velayutham@lnttechservices.com
> > > +1-309-740-7691
> > >
> > > -----Original Message-----
> > > From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> > > Sent: Saturday, April 09, 2016 6:40 AM
> > > To: Dinesh Velayudham
> > > Cc: gianluca; linux-can@vger.kernel.org
> > > Subject: Re: J1939 Linux
> > >
> > >
> > > --- Original message ---
> > > > Date: Fri, 8 Apr 2016 14:29:02 +0000
> > > > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > > > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, gianluca
> > > > <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> > > >  <linux-can@vger.kernel.org>
> > > > Subject: RE: J1939 Linux
> > > >
> > > > Kurt and Eurek,
> > > > I did follow the same steps except that I did not enable J1939 option in menuconfig.
> > > > The build was successful and I am able to install the new custom kernel and reboot without any issues.
> > > > Looks like I am facing the problem only when I enable J1939 option under menuconfig.
> > > >
> > > > Hope this helps you to narrow down the problem.
> > >
> > > On my Slackware, I get as far as:
> > >
> > >         INSTALL debian/headertmp/usr/include/linux/wimax/ (1 file)
> > >         INSTALL debian/headertmp/usr/include/linux/ (420 files)
> > >         INSTALL debian/headertmp/usr/include/asm/ (65 files)
> > >         Using default distribution of 'unstable' in the changelog
> > >         Install lsb-release or set $KDEB_CHANGELOG_DIST explicitly
> > >         ./scripts/package/builddeb: line 31: dpkg-gencontrol: command not found
> > >         make[1]: *** [deb-pkg] Error 127
> > >         make: *** [deb-pkg] Error 2
> > >
> > > This is anyhow beyond my expertise.
> > > Since it clearly seems to be caused by my can-j1939, I will help to find it. Can you show a bit more output where the build fails?
> > > Possibly with V=2 commandline parameter?
> > >
> > > Kurt
> > > L&T Technology Services Ltd
> > >
> > > www.LntTechservices.com<http://www.lnttechservices.com/>
> > >
> > > This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.
> >
> L&T Technology Services Ltd
> 
> www.LntTechservices.com<http://www.lnttechservices.com/>
> 
> This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

Re: J1939 Linux

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 721 bytes --]

On 04/14/2016 12:03 PM, Kurt Van Dijck wrote:
> I pushed j1939d-v3.19.
> 
> I created the branch by merging & cherry-pick, as suggested earlier.
> I didn't have compile problems.
> 
> I have not tested it, yet I foresee no problems, or at least no
> differences compared to my other j1939d-vx.xx branches.

I want to do the first steps of mainlining j1939. Which is the preferred
branch? I've started with j1939/j1939d-v4.3.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: J1939 Linux

[Kurt Van Dijck]

> On 04/14/2016 12:03 PM, Kurt Van Dijck wrote:
> > I pushed j1939d-v3.19.
> > 
> > I created the branch by merging & cherry-pick, as suggested earlier.
> > I didn't have compile problems.
> > 
> > I have not tested it, yet I foresee no problems, or at least no
> > differences compared to my other j1939d-vx.xx branches.
> 
> I want to do the first steps of mainlining j1939. Which is the preferred
> branch? I've started with j1939/j1939d-v4.3.

I'm not sure if mainlining introduces a big squash, or a regular merge.
I'd say that j1939d-v4.1 show a cleaner history.
The only reason for existence of j1939-v4.3 is that I was working with a
v4.3 at that point.

Kurt

Re: J1939 Linux

[Marc Kleine-Budde]

[-- Attachment #1.1: Type: text/plain, Size: 1292 bytes --]

On 04/14/2016 02:22 PM, Kurt Van Dijck wrote:
>> On 04/14/2016 12:03 PM, Kurt Van Dijck wrote:
>>> I pushed j1939d-v3.19.
>>>
>>> I created the branch by merging & cherry-pick, as suggested earlier.
>>> I didn't have compile problems.
>>>
>>> I have not tested it, yet I foresee no problems, or at least no
>>> differences compared to my other j1939d-vx.xx branches.
>>
>> I want to do the first steps of mainlining j1939. Which is the preferred
>> branch? I've started with j1939/j1939d-v4.3.
> 
> I'm not sure if mainlining introduces a big squash, or a regular merge.

I'll first squash everything and then probably move the bits modifying
existing files into a separate patch.

> I'd say that j1939d-v4.1 show a cleaner history.

I'll rebase both to v4.5 to see if there's a difference.

> The only reason for existence of j1939-v4.3 is that I was working with a
                                   ^^^^^^^^^^
You mean "j1939d-v4.3" with a "d".

> v4.3 at that point.

thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: J1939 Linux

[Kurt Van Dijck]

>> The only reason for existence of j1939-v4.3 is that I was working
>with a
>                                   ^^^^^^^^^^
>You mean "j1939d-v4.3" with a "d".
Ack
>
>> v4.3 at that point.
>
>thanks,
>Marc

RE: J1939 Linux

[Dinesh Velayudham]

Kurt,
Appreciate your time and getting a new branch. Using v3.19 I am able to build, install and reboot to the custom kernel. I am also able to load j1939 kernel module.
Now I am facing an new issue. I was trying to compile the "test-can-j1939" test application and "make" gave an error that it is unable to find
J1939.h header file under "include/linux/can/j1939.h".
So explored both the kernel header file package (*.deb file) and also the source directory and I am unable to locate j1939.h file under "include/linux/can/j1939.h". Rather I can see j1939.h file under the following places
1. "include/config/can"
2. "include/uapi/linux/can"
3. "usr/include/linux/can"
I tried to compare this path with installed kernel headers under "/usr/src/linux-headers-3.19.0-custom" and I could find them in
1. "include/uapi/linux/can/j1939.h"
2. "include/config/can/j1939.h"
But not in "include/linux/can"
Any suggestions?


Regards
Dinesh Velayudham
L&T Technology Services
dinesh.velayutham@lnttechservices.com
+1-309-740-7691

-----Original Message-----
From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
Sent: Thursday, April 14, 2016 5:03 AM
To: Dinesh Velayudham
Cc: gianluca; linux-can@vger.kernel.org
Subject: Re: J1939 Linux

I pushed j1939d-v3.19.

I created the branch by merging & cherry-pick, as suggested earlier.
I didn't have compile problems.

I have not tested it, yet I foresee no problems, or at least no differences compared to my other j1939d-vx.xx branches.

Kind regards,
Kurt

--- Original message ---
> Date: Wed, 13 Apr 2016 16:08:33 +0000
> From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
>  <linux-can@vger.kernel.org>
> Subject: RE: J1939 Linux
>
> Kurt,
> Do you have v3.19 for me to build and test?
>
>
> Regards
> Dinesh Velayudham
> L&T Technology Services
> dinesh.velayutham@lnttechservices.com
> +1-309-740-7691
>
> -----Original Message-----
> From: Dinesh Velayudham
> Sent: Tuesday, April 12, 2016 1:28 PM
> To: 'Kurt Van Dijck'
> Cc: gianluca; linux-can@vger.kernel.org
> Subject: RE: J1939 Linux
>
> I don’t think this will work as the cherry-pick only changes the
> socket.c file. The " memcpy_toiovec" has been used in few more places
> e.g /include/linux/skbuff.h,
>
>
> Regards
> Dinesh Velayudham
> L&T Technology Services
> dinesh.velayutham@lnttechservices.com
> +1-309-740-7691
>
> -----Original Message-----
> From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> Sent: Tuesday, April 12, 2016 1:16 PM
> To: Dinesh Velayudham
> Cc: gianluca; linux-can@vger.kernel.org
> Subject: Re: J1939 Linux
>
> I apologise, I have given you the wrong commit to cherry-pick.
> I gave the API change commit, and you need the one that adapts it for can-j1939.
> So forget the previous email (reset the git HEAD) and do
>
>         git cherry-pick 34bb840
>
> Kind regards,
> Kurt
>
> --- Original message ---
> > Date: Tue, 12 Apr 2016 17:57:02 +0000
> > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> > CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> >  <linux-can@vger.kernel.org>
> > Subject: RE: J1939 Linux
> >
> > Kurt,
> > I am still facing build error
> > 1. cherry pick the code
> > 2. make clean
> > 3. make deb-pkg
> >
> > $ git cherry-pick 7eab8d9e
> > [master bf6fe85] new helper: memcpy_to_msg()
> >  Author: Al Viro <viro@zeniv.linux.org.uk>
> >  1 file changed, 5 insertions(+)
> >
> > $ make clean
> >   CLEAN   .
> >   CLEAN   arch/x86/kernel/cpu
> >   CLEAN   arch/x86/kernel
> >   CLEAN   arch/x86/purgatory
> >   CLEAN   arch/x86/realmode/rm
> >   CLEAN   arch/x86/vdso
> >   CLEAN   arch/x86/lib
> >   CLEAN   crypto/asymmetric_keys
> >   CLEAN   drivers/gpu/drm/radeon
> >   CLEAN   drivers/net/wan
> >   CLEAN   drivers/scsi/aic7xxx
> >   CLEAN   drivers/tty/vt
> >   CLEAN   firmware
> >   CLEAN   kernel/debug/kdb
> >   CLEAN   kernel/time
> >   CLEAN   kernel
> >   CLEAN   lib/raid6
> >   CLEAN   lib
> >   CLEAN   security/apparmor
> >   CLEAN   security/selinux
> >   CLEAN   usr
> >   CLEAN   arch/x86/boot/compressed
> >   CLEAN   arch/x86/boot
> >   CLEAN   arch/x86/tools
> >   CLEAN   .tmp_versions
> >
> > $ make -j 4 V=2 deb-pkg LOCALVERSION=-custom 2>&1 | tee buildlog.txt
> > In file included from include/crypto/algapi.h:18:0,
> >                  from include/crypto/internal/hash.h:16,
> >                  from arch/x86/crypto/crc32c-intel_glue.c:31:
> > include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
> >  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h:2705:19: note: previous definition of
> > ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> > include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >   ^
> > include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >                            ^
> > cc1: some warnings being treated as errors
> > make[4]: *** [arch/x86/crypto/crc32c-intel_glue.o] Error 1
> > make[3]: *** [arch/x86/crypto] Error 2
> > make[3]: *** Waiting for unfinished jobs....
> >   CC      kernel/exec_domain.o - due to target missing
> >   CC      arch/x86/ia32/ia32_signal.o - due to target missing
> >   CC      init/do_mounts.o - due to target missing
> > In file included from include/linux/netfilter.h:5:0,
> >                  from include/net/netns/netfilter.h:5,
> >                  from include/net/net_namespace.h:22,
> >                  from include/linux/init_task.h:15,
> >                  from kernel/fork.c:534:
> > include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
> >  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h:2705:19: note: previous definition of
> > ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> > include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >   ^
> > include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >                            ^
> > cc1: some warnings being treated as errors
> > make[3]: *** [kernel/fork.o] Error 1
> > make[2]: *** [kernel] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >   CC      init/do_mounts_rd.o - due to target missing
> >   CC      arch/x86/ia32/nosyscall.o - due to target missing
> >   CC      arch/x86/ia32/syscall_ia32.o - due to target missing
> >   CC      init/do_mounts_initrd.o - due to target missing
> >   CC      arch/x86/ia32/audit.o - due to target missing
> >   LD      arch/x86/ia32/built-in.o - due to target missing
> > make[2]: *** [arch/x86] Error 2
> >   CC      init/do_mounts_md.o - due to target missing
> > In file included from include/linux/icmpv6.h:4:0,
> >                  from include/linux/ipv6.h:63,
> >                  from include/net/ipv6.h:16,
> >                  from include/linux/sunrpc/clnt.h:27,
> >                  from include/linux/nfs_fs.h:30,
> >                  from init/do_mounts.c:32:
> > include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
> >  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h:2705:19: note: previous definition of
> > ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> > include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >   ^
> > include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >                            ^
> >   CC      init/initramfs.o - due to target missing
> >   CC      init/calibrate.o - due to target missing
> >   CC      init/init_task.o - due to target missing
> >   CC      init/version.o - due to target missing
> > cc1: some warnings being treated as errors
> > make[3]: *** [init/do_mounts.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....
> > In file included from include/linux/netfilter.h:5:0,
> >                  from include/net/netns/netfilter.h:5,
> >                  from include/net/net_namespace.h:22,
> >                  from include/linux/init_task.h:15,
> >                  from init/init_task.c:1:
> > include/linux/skbuff.h:2710:19: error: redefinition of ‘memcpy_to_msg’
> >  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h:2705:19: note: previous definition of
> > ‘memcpy_to_msg’ was here  static inline int memcpy_to_msg(struct msghdr *msg, void *data, int len)
> >                    ^
> > include/linux/skbuff.h: In function ‘memcpy_to_msg’:
> > include/linux/skbuff.h:2712:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >   ^
> > include/linux/skbuff.h:2712:27: error: ‘struct msghdr’ has no member named ‘msg_iov’
> >   return memcpy_toiovec(msg->msg_iov, data, len);
> >                            ^
> > cc1: some warnings being treated as errors
> > make[3]: *** [init/init_task.o] Error 1
> > make[2]: *** [init] Error 2
> > make[1]: *** [deb-pkg] Error 2
> > make: *** [deb-pkg] Error 2
> >
> >
> > Regards
> > Dinesh Velayudham
> > L&T Technology Services
> > dinesh.velayutham@lnttechservices.com
> > +1-309-740-7691
> >
> > -----Original Message-----
> > From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> > Sent: Tuesday, April 12, 2016 3:20 AM
> > To: Dinesh Velayudham
> > Cc: gianluca; linux-can@vger.kernel.org
> > Subject: Re: J1939 Linux
> >
> > Ok, I see.
> > It had nothing to do with "make deb-pkg", it is a problem that I
> > didn't see that commit 7eab8d9e is necessary as of v3.19, where I
> > only saw that v4.1 needed it.
> >
> > Please do:
> >
> >         $ git cherry-pick 7eab8d9e
> >
> > and the make should succeed.
> >
> > Sorry for not seeing this. I will try to prepare a j1939d-v3.19
> > branch, which will have that commit included.
> >
> > Kind regards,
> > Kurt
> >
> > --- Original message ---
> > > Date: Mon, 11 Apr 2016 22:11:11 +0000
> > > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
> > > CC: gianluca <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> > >  <linux-can@vger.kernel.org>
> > > Subject: RE: J1939 Linux
> > >
> > > Kurt,
> > > I have attached text file that contains output of make command
> > > with V=2. Incase if you are not able to see the attached text
> > > file. Below is part of make command output
> > > -------------------------------------
> > >   CC      lib/strncpy_from_user.o - due to target missing
> > >   CC [M]  net/can/j1939/socket.o - due to target missing
> > >   CC      lib/strnlen_user.o - due to target missing
> > > net/can/j1939/socket.c: In function ‘j1939sk_recvmsg’:
> > > net/can/j1939/socket.c:621:2: error: implicit declaration of function ‘memcpy_toiovec’ [-Werror=implicit-function-declaration]
> > >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> > >   ^
> > > net/can/j1939/socket.c:621:26: error: ‘struct msghdr’ has no member named ‘msg_iov’
> > >   ret = memcpy_toiovec(msg->msg_iov, skb->data, size);
> > >                           ^
> > > net/can/j1939/socket.c: In function ‘j1939sk_sendmsg’:
> > > net/can/j1939/socket.c:708:48: error: ‘struct msghdr’ has no member named ‘msg_iov’
> > >   ret = memcpy_fromiovec(skb_put(skb, size), msg->msg_iov, size);
> > >                                                 ^
> > > cc1: some warnings being treated as errors
> > >   CC      lib/net_utils.o - due to target missing
> > > make[5]: *** [net/can/j1939/socket.o] Error 1
> > > make[4]: *** [net/can/j1939] Error 2
> > > make[3]: *** [net/can] Error 2
> > > make[2]: *** [net] Error 2
> > > make[2]: *** Waiting for unfinished jobs....
> > >
> > > ---------------------------------------------------
> > >
> > > Regards
> > > Dinesh Velayudham
> > > L&T Technology Services
> > > dinesh.velayutham@lnttechservices.com
> > > +1-309-740-7691
> > >
> > > -----Original Message-----
> > > From: Kurt Van Dijck [mailto:dev.kurt@vandijck-laurijssen.be]
> > > Sent: Saturday, April 09, 2016 6:40 AM
> > > To: Dinesh Velayudham
> > > Cc: gianluca; linux-can@vger.kernel.org
> > > Subject: Re: J1939 Linux
> > >
> > >
> > > --- Original message ---
> > > > Date: Fri, 8 Apr 2016 14:29:02 +0000
> > > > From: Dinesh Velayudham <Dinesh.Velayutham@LnTtechservices.com>
> > > > To: Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>, gianluca
> > > > <gianlucarenzi@eurek.it>, "linux-can@vger.kernel.org"
> > > >  <linux-can@vger.kernel.org>
> > > > Subject: RE: J1939 Linux
> > > >
> > > > Kurt and Eurek,
> > > > I did follow the same steps except that I did not enable J1939 option in menuconfig.
> > > > The build was successful and I am able to install the new custom kernel and reboot without any issues.
> > > > Looks like I am facing the problem only when I enable J1939 option under menuconfig.
> > > >
> > > > Hope this helps you to narrow down the problem.
> > >
> > > On my Slackware, I get as far as:
> > >
> > >         INSTALL debian/headertmp/usr/include/linux/wimax/ (1 file)
> > >         INSTALL debian/headertmp/usr/include/linux/ (420 files)
> > >         INSTALL debian/headertmp/usr/include/asm/ (65 files)
> > >         Using default distribution of 'unstable' in the changelog
> > >         Install lsb-release or set $KDEB_CHANGELOG_DIST explicitly
> > >         ./scripts/package/builddeb: line 31: dpkg-gencontrol: command not found
> > >         make[1]: *** [deb-pkg] Error 127
> > >         make: *** [deb-pkg] Error 2
> > >
> > > This is anyhow beyond my expertise.
> > > Since it clearly seems to be caused by my can-j1939, I will help to find it. Can you show a bit more output where the build fails?
> > > Possibly with V=2 commandline parameter?
> > >
> > > Kurt
> > > L&T Technology Services Ltd
> > >
> > > www.LntTechservices.com<http://www.lnttechservices.com/>
> > >
> > > This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.
> >
> L&T Technology Services Ltd
>
> www.LntTechservices.com<http://www.lnttechservices.com/>
>
> This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.
L&T Technology Services Ltd

www.LntTechservices.com<http://www.lnttechservices.com/>

This Email may contain confidential or privileged information for the intended recipient (s). If you are not the intended recipient, please do not use or disseminate the information, notify the sender and delete it from your system.

Re: J1939 Linux

[Kurt Van Dijck]

> Kurt,
> Appreciate your time and getting a new branch. Using v3.19 I am able to build, install and reboot to the custom kernel. I am also able to load j1939 kernel module.
> Now I am facing an new issue. I was trying to compile the "test-can-j1939" test application and "make" gave an error that it is unable to find
> J1939.h header file under "include/linux/can/j1939.h".
> So explored both the kernel header file package (*.deb file) and also the source directory and I am unable to locate j1939.h file under "include/linux/can/j1939.h". Rather I can see j1939.h file under the following places
> 1. "include/config/can"
> 2. "include/uapi/linux/can"
> 3. "usr/include/linux/can"
> I tried to compare this path with installed kernel headers under "/usr/src/linux-headers-3.19.0-custom" and I could find them in
> 1. "include/uapi/linux/can/j1939.h"
> 2. "include/config/can/j1939.h"
> But not in "include/linux/can"
> Any suggestions?

in the kernel source (j1939d-v3.19), the command
	$ git ls-files | grep j1939
yiels
	include/uapi/linux/can/j1939.h

All other files are intermediate copies.
Unfortunately, I'm not so well qualified in the deb-pkg build process.
I'm not sure what to think of it.

IMO, any header file in include/uapi will be taken unconditionally with
	$ make headers_install

To fast-forward:
	cp <repository>/include/uapi/linux/can.h /usr/include/linux/
	cp <repository>/include/uapi/linux/can/j1939.h /usr/include/linux/can/

This should make things work.

You should note that the size of struct can_addr increases.
Both the old & new size are accepted by the new kernel, i.e. you do not
need to recompile binaries that use can_raw etc. like candump ...
They work unmodified.
The new size of struct can_addr is however not accepted by the mainline
kernel (yet). So, if you replace the can.h header file, and recompile
can-utils, then candump will not work properly on non-j1939 kernels.
So, make a copy of the existing can.h header!

Kind regards,
Kurt