From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Wolf Subject: Re: [Qemu-devel] [PATCH v8 2/4] block: add the command line support Date: Mon, 17 Oct 2011 12:19:46 +0200 Message-ID: <4E9C0142.3030107@redhat.com> References: <1315476668-19812-1-git-send-email-wuzhy@linux.vnet.ibm.com> <1315476668-19812-3-git-send-email-wuzhy@linux.vnet.ibm.com> <4E7CABC0.4050501@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, pair@us.ibm.com, ryanh@us.ibm.com, Zhi Yong Wu To: Zhi Yong Wu Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4590 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225Ab1JQKQr (ORCPT ); Mon, 17 Oct 2011 06:16:47 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Am 26.09.2011 08:15, schrieb Zhi Yong Wu: > On Fri, Sep 23, 2011 at 11:54 PM, Kevin Wolf wrote: >>> +} >>> + >>> +static void bdrv_block_timer(void *opaque) >>> +{ >>> + BlockDriverState *bs = opaque; >>> + BlockQueue *queue = bs->block_queue; >>> + >>> + qemu_block_queue_flush(queue); >> >> Hm, didn't really notice it while reading patch 1, but >> qemu_block_queue_flush() is misleading. It's really something like > Why do you say this is misleading? >> qemu_block_queue_submit(). > Right. It will resubmit all enqueued I/O requests. For me, flush sounds as if it waits for completion of all requests. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55242) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFkFV-0001Wl-MY for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:16:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RFkFR-0006I7-Qx for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:16:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36264) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RFkFR-0006I3-Ha for qemu-devel@nongnu.org; Mon, 17 Oct 2011 06:16:45 -0400 Message-ID: <4E9C0142.3030107@redhat.com> Date: Mon, 17 Oct 2011 12:19:46 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1315476668-19812-1-git-send-email-wuzhy@linux.vnet.ibm.com> <1315476668-19812-3-git-send-email-wuzhy@linux.vnet.ibm.com> <4E7CABC0.4050501@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v8 2/4] block: add the command line support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhi Yong Wu Cc: pair@us.ibm.com, stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org, mtosatti@redhat.com, Zhi Yong Wu , aliguori@us.ibm.com, qemu-devel@nongnu.org, ryanh@us.ibm.com Am 26.09.2011 08:15, schrieb Zhi Yong Wu: > On Fri, Sep 23, 2011 at 11:54 PM, Kevin Wolf wrote: >>> +} >>> + >>> +static void bdrv_block_timer(void *opaque) >>> +{ >>> + BlockDriverState *bs = opaque; >>> + BlockQueue *queue = bs->block_queue; >>> + >>> + qemu_block_queue_flush(queue); >> >> Hm, didn't really notice it while reading patch 1, but >> qemu_block_queue_flush() is misleading. It's really something like > Why do you say this is misleading? >> qemu_block_queue_submit(). > Right. It will resubmit all enqueued I/O requests. For me, flush sounds as if it waits for completion of all requests. Kevin