From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIfxf-0002Vc-Eb for qemu-devel@nongnu.org; Tue, 25 Oct 2011 08:18:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIfxe-0007Uw-81 for qemu-devel@nongnu.org; Tue, 25 Oct 2011 08:18:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIfxd-0007U4-TN for qemu-devel@nongnu.org; Tue, 25 Oct 2011 08:18:30 -0400 Message-ID: <4EA6A9CD.5080103@redhat.com> Date: Tue, 25 Oct 2011 14:21:33 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1314891739-1881-1-git-send-email-kraxel@redhat.com> <20111024184320.GA29718@otherpad.lan.raisama.net> <4EA5B51F.8040502@codemonkey.ws> In-Reply-To: <4EA5B51F.8040502@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] add "make check" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Avi Kivity , Markus Armbruster , Gerd Hoffmann Am 24.10.2011 20:57, schrieb Anthony Liguori: > On 10/24/2011 01:43 PM, Eduardo Habkost wrote: >> On Mon, Sep 05, 2011 at 09:55:20AM +0200, Markus Armbruster wrote: >>> Gerd Hoffmann writes: >>> >>>> Hi, >>>> >>>> This patch series intends to make unit testing easier. It adds a new >>>> "make check" target which can be used to run all unit tests which are >>>> currently in the tree. It also enables the unit tests by default, so >>>> you don't have to re-run configure with a special switch. >>> >>> Reviewed-by: Markus Armbruster >>> >>> One test fails, but Luiz has a fix in his tree. >> >> Reviewed-by: Eduardo Habkost >> >> Now all tests are passing. Why this was not applied yet? > > I was hoping for more, but maybe we just need to start here and grow > organically, I'll queue it again. A while ago I played with some simple IDE tests. It basically was a small x86 kernel with an empty image that sends IDE commands and prints some results, and a script that invokes the guest and checks whether the test has passed or failed. So at first I started with my own multiboot kernel and copied over some parts of kvm-unittest's libc. Clearly not the best idea once it's more than a couple of lines, so at some point I took the code and integrated with my real kvm-unittests repository. Now I don't have to duplicate code any more, but at the same time there's no chance that a 'make check' in an upstream qemu tree could run this. Tests for other devices will have exactly the same problem. Any suggestions on how to go forward with this kind of tests? Should this go into qemu or into kvm-unittests? Or should kvm-unittests be merged into the qemu tree? Or is the approach completely wrong? Kevin