From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIiX6-0003Mn-Pm for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:03:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RIiX2-0005CZ-EJ for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:03:16 -0400 Received: from mail-gx0-f173.google.com ([209.85.161.173]:39121) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RIiX2-0005CR-Bi for qemu-devel@nongnu.org; Tue, 25 Oct 2011 11:03:12 -0400 Received: by ggnr5 with SMTP id r5so693819ggn.4 for ; Tue, 25 Oct 2011 08:03:11 -0700 (PDT) Message-ID: <4EA6CFAB.9060702@codemonkey.ws> Date: Tue, 25 Oct 2011 10:03:07 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1314891739-1881-1-git-send-email-kraxel@redhat.com> <20111024184320.GA29718@otherpad.lan.raisama.net> <4EA5B51F.8040502@codemonkey.ws> <4EA6A9CD.5080103@redhat.com> In-Reply-To: <4EA6A9CD.5080103@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] add "make check" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Markus Armbruster , Gerd Hoffmann , qemu-devel@nongnu.org, Avi Kivity On 10/25/2011 07:21 AM, Kevin Wolf wrote: > Am 24.10.2011 20:57, schrieb Anthony Liguori: >> On 10/24/2011 01:43 PM, Eduardo Habkost wrote: >>> On Mon, Sep 05, 2011 at 09:55:20AM +0200, Markus Armbruster wrote: >>>> Gerd Hoffmann writes: >>>> >>>>> Hi, >>>>> >>>>> This patch series intends to make unit testing easier. It adds a new >>>>> "make check" target which can be used to run all unit tests which are >>>>> currently in the tree. It also enables the unit tests by default, so >>>>> you don't have to re-run configure with a special switch. >>>> >>>> Reviewed-by: Markus Armbruster >>>> >>>> One test fails, but Luiz has a fix in his tree. >>> >>> Reviewed-by: Eduardo Habkost >>> >>> Now all tests are passing. Why this was not applied yet? >> >> I was hoping for more, but maybe we just need to start here and grow >> organically, I'll queue it again. > > A while ago I played with some simple IDE tests. It basically was a > small x86 kernel with an empty image that sends IDE commands and prints > some results, and a script that invokes the guest and checks whether the > test has passed or failed. > > So at first I started with my own multiboot kernel and copied over some > parts of kvm-unittest's libc. Clearly not the best idea once it's more > than a couple of lines, so at some point I took the code and integrated > with my real kvm-unittests repository. I did something very similar. I just added PCI support to kvm-unittests such that I could write a small virtio driver. I actually do think tests like this could live in a make check framework in QEMU. Regards, Anthony Liguori > > Now I don't have to duplicate code any more, but at the same time > there's no chance that a 'make check' in an upstream qemu tree could run > this. Tests for other devices will have exactly the same problem. > > Any suggestions on how to go forward with this kind of tests? Should > this go into qemu or into kvm-unittests? Or should kvm-unittests be > merged into the qemu tree? Or is the approach completely wrong? > > Kevin >