Re: [PATCH 0/2] Use generic code for virtual address of randomization of x86

From: Kees Cook <keescook@chromium.org>
To: sxwjean@me.com, x86@kernel.org, linux-mm@kvack.org
Cc: Xiongwei Song <sxwjean@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andy Lutomirski <luto@kernel.org>,
	Gabriel Krisman Bertazi <krisman@collabora.com>,
	"Chang S. Bae" <chang.seok.bae@intel.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Arvind Sankar <nivedita@alum.mit.edu>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Oleg Nesterov <oleg@redhat.com>, Balbir Singh <sblbir@amazon.com>,
	Jens Axboe <axboe@kernel.dk>,
	Lai Jiangshan <laijs@linux.alibaba.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"David S. Miller" <davem@davemloft.net>,
	Kim Phillips <kim.phillips@amd.com>,
	Yazen Ghannam <yazen.ghannam@amd.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	Stefan Metzmacher <metze@samba.org>,
	Marco Elver <elver@google.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Use generic code for virtual address of randomization of x86
Date: Tue, 21 Sep 2021 06:24:07 -0700	[thread overview]
Message-ID: <4EB3D825-264D-447A-8C55-FA0CE8BC31F6@chromium.org> (raw)
In-Reply-To: <20210921110252.2593542-1-sxwjean@me.com>

On September 21, 2021 4:02:50 AM PDT, sxwjean@me.com wrote:
>From: Xiongwei Song <sxwjean@gmail.com>
>
>Hello,
>
>The two patches are to use generic code for randomization of virtual
>address of x86. Since the basic code logic of x86 is same as generic
>code, so no need to implement these functions on x86, please see the
>details in comments of patch 2.

Hi!

The other patches do not seem to have arrived; I only see 0/2.

-Kees

>
>Please review it.
>
>Cc: Thomas Gleixner <tglx@linutronix.de>
>Cc: Ingo Molnar <mingo@redhat.com>
>Cc: Borislav Petkov <bp@alien8.de>
>Cc: "H. Peter Anvin" <hpa@zytor.com>
>Cc: Andy Lutomirski <luto@kernel.org>
>Cc: Gabriel Krisman Bertazi <krisman@collabora.com>
>Cc: "Chang S. Bae" <chang.seok.bae@intel.com>
>Cc: Al Viro <viro@zeniv.linux.org.uk>
>Cc: Arvind Sankar <nivedita@alum.mit.edu>
>Cc: Alexey Dobriyan <adobriyan@gmail.com>
>Cc: Oleg Nesterov <oleg@redhat.com>
>Cc: Balbir Singh <sblbir@amazon.com>
>Cc: Jens Axboe <axboe@kernel.dk>
>Cc: Lai Jiangshan <laijs@linux.alibaba.com>
>Cc: Dave Hansen <dave.hansen@linux.intel.com>
>Cc: Peter Zijlstra <peterz@infradead.org>
>Cc: Andrew Morton <akpm@linux-foundation.org>
>Cc: Arnd Bergmann <arnd@arndb.de>
>Cc: "David S. Miller" <davem@davemloft.net>
>Cc: Kees Cook <keescook@chromium.org>
>Cc: Kim Phillips <kim.phillips@amd.com>
>Cc: Yazen Ghannam <yazen.ghannam@amd.com>
>Cc: Davidlohr Bueso <dave@stgolabs.net>
>Cc: Stefan Metzmacher <metze@samba.org>
>Cc: Marco Elver <elver@google.com>
>Cc: "Eric W. Biederman" <ebiederm@xmission.com>
>Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>Cc: linux-kernel@vger.kernel.org
>
>Xiongwei Song (2):
>  x86: Rename TIF_ADDR32 to TIF_32BIT
>  x86/mm: Randomize va with generic arch_pick_mmap_layout()
>
> arch/x86/Kconfig                     |   2 +-
> arch/x86/include/asm/compat.h        |   7 +-
> arch/x86/include/asm/elf.h           |   2 +-
> arch/x86/include/asm/page_64_types.h |   6 +-
> arch/x86/include/asm/processor.h     |   4 +-
> arch/x86/include/asm/thread_info.h   |   4 +-
> arch/x86/kernel/process.c            |   5 --
> arch/x86/kernel/process_64.c         |   4 +-
> arch/x86/mm/mmap.c                   | 112 ---------------------------
> include/linux/compat.h               |   4 +
> mm/util.c                            |  18 ++++-
> 11 files changed, 37 insertions(+), 131 deletions(-)
>