From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754416Ab1KFTLH (ORCPT ); Sun, 6 Nov 2011 14:11:07 -0500 Received: from mail-ww0-f44.google.com ([74.125.82.44]:53855 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139Ab1KFTLF (ORCPT ); Sun, 6 Nov 2011 14:11:05 -0500 Message-ID: <4EB6DBC6.2010404@redhat.com> Date: Sun, 06 Nov 2011 20:11:02 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Pekka Enberg CC: Alexander Graf , "kvm@vger.kernel.org list" , qemu-devel Developers , "linux-kernel@vger.kernel.org List" , Blue Swirl , Avi Kivity , =?ISO-8859-1?Q?Am=E9rico_Wang?= , Ingo Molnar , Linus Torvalds Subject: Re: [PATCH] KVM: Add wrapper script around QEMU to test kernels References: <1320543320-32728-1-git-send-email-agraf@suse.de> <4EB65C5B.8070709@redhat.com> <4EB66036.4080102@redhat.com> <1320577728.1428.73.camel@jaguar> <4EB67486.1070105@redhat.com> <4EB67D17.7000701@redhat.com> <4EB680D9.2070706@redhat.com> <877C82F4-F07C-44AA-8722-3AF57CFC4597@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2011 06:28 PM, Pekka Enberg wrote: > On Sun, Nov 6, 2011 at 7:15 PM, Alexander Graf wrote: >>> The difference here is that although I feel Alex's script is a >>> pointless project, I'm in no way opposed to merging it in the tree if >>> people use it and it solves their problem. Some people seem to be >>> violently opposed to merging the KVM tool and I'm having difficult >>> time understanding why that is. >> >> It's a matter of size and scope. Write a shell script that clones, builds and >> executes KVM Tool and throw it in testing/tools/ and I'll happily ack it! > > That's pretty much what git submodule would do, isn't it? Absolutely not. It would always fetch HEAD from the KVM tool repo. A submodule ties each supermodule commit to a particular submodule commit. > I really don't see the point in doing that. We want to be part of > regular kernel history and release cycle. But I'm pretty certain that, when testing 3.2 with KVM tool in a couple of years, I want all the shining new features you added in this time; I don't want the old end-2011 code. Same if I'm bisecting kernels, I don't want to build KVM tool once per bisection cycle, do I? Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: Add wrapper script around QEMU to test kernels Date: Sun, 06 Nov 2011 20:11:02 +0100 Message-ID: <4EB6DBC6.2010404@redhat.com> References: <1320543320-32728-1-git-send-email-agraf@suse.de> <4EB65C5B.8070709@redhat.com> <4EB66036.4080102@redhat.com> <1320577728.1428.73.camel@jaguar> <4EB67486.1070105@redhat.com> <4EB67D17.7000701@redhat.com> <4EB680D9.2070706@redhat.com> <877C82F4-F07C-44AA-8722-3AF57CFC4597@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "kvm@vger.kernel.org list" , qemu-devel Developers , "linux-kernel@vger.kernel.org List" , Alexander Graf , Blue Swirl , Avi Kivity , =?ISO-8859-1?Q?Am=E9rico_Wang?= , Ingo Molnar , Linus Torvalds To: Pekka Enberg Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 11/06/2011 06:28 PM, Pekka Enberg wrote: > On Sun, Nov 6, 2011 at 7:15 PM, Alexander Graf wrote: >>> The difference here is that although I feel Alex's script is a >>> pointless project, I'm in no way opposed to merging it in the tree if >>> people use it and it solves their problem. Some people seem to be >>> violently opposed to merging the KVM tool and I'm having difficult >>> time understanding why that is. >> >> It's a matter of size and scope. Write a shell script that clones, builds and >> executes KVM Tool and throw it in testing/tools/ and I'll happily ack it! > > That's pretty much what git submodule would do, isn't it? Absolutely not. It would always fetch HEAD from the KVM tool repo. A submodule ties each supermodule commit to a particular submodule commit. > I really don't see the point in doing that. We want to be part of > regular kernel history and release cycle. But I'm pretty certain that, when testing 3.2 with KVM tool in a couple of years, I want all the shining new features you added in this time; I don't want the old end-2011 code. Same if I'm bisecting kernels, I don't want to build KVM tool once per bisection cycle, do I? Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RN87Y-00008p-Pd for qemu-devel@nongnu.org; Sun, 06 Nov 2011 14:11:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RN87X-0007Hi-JD for qemu-devel@nongnu.org; Sun, 06 Nov 2011 14:11:08 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:52609) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RN87X-0007Hc-9N for qemu-devel@nongnu.org; Sun, 06 Nov 2011 14:11:07 -0500 Received: by wwg7 with SMTP id 7so5112814wwg.10 for ; Sun, 06 Nov 2011 11:11:03 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4EB6DBC6.2010404@redhat.com> Date: Sun, 06 Nov 2011 20:11:02 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1320543320-32728-1-git-send-email-agraf@suse.de> <4EB65C5B.8070709@redhat.com> <4EB66036.4080102@redhat.com> <1320577728.1428.73.camel@jaguar> <4EB67486.1070105@redhat.com> <4EB67D17.7000701@redhat.com> <4EB680D9.2070706@redhat.com> <877C82F4-F07C-44AA-8722-3AF57CFC4597@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pekka Enberg Cc: "kvm@vger.kernel.org list" , qemu-devel Developers , "linux-kernel@vger.kernel.org List" , Alexander Graf , Blue Swirl , Avi Kivity , =?ISO-8859-1?Q?Am=E9rico_Wang?= , Ingo Molnar , Linus Torvalds On 11/06/2011 06:28 PM, Pekka Enberg wrote: > On Sun, Nov 6, 2011 at 7:15 PM, Alexander Graf wrote: >>> The difference here is that although I feel Alex's script is a >>> pointless project, I'm in no way opposed to merging it in the tree if >>> people use it and it solves their problem. Some people seem to be >>> violently opposed to merging the KVM tool and I'm having difficult >>> time understanding why that is. >> >> It's a matter of size and scope. Write a shell script that clones, builds and >> executes KVM Tool and throw it in testing/tools/ and I'll happily ack it! > > That's pretty much what git submodule would do, isn't it? Absolutely not. It would always fetch HEAD from the KVM tool repo. A submodule ties each supermodule commit to a particular submodule commit. > I really don't see the point in doing that. We want to be part of > regular kernel history and release cycle. But I'm pretty certain that, when testing 3.2 with KVM tool in a couple of years, I want all the shining new features you added in this time; I don't want the old end-2011 code. Same if I'm bisecting kernels, I don't want to build KVM tool once per bisection cycle, do I? Paolo