From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932284Ab1KGM0u (ORCPT ); Mon, 7 Nov 2011 07:26:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40028 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200Ab1KGM0t (ORCPT ); Mon, 7 Nov 2011 07:26:49 -0500 Message-ID: <4EB7CE71.50401@redhat.com> Date: Mon, 07 Nov 2011 14:26:25 +0200 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Sasha Levin CC: Gerd Hoffmann , Pekka Enberg , "kvm@vger.kernel.org list" , qemu-devel Developers , "linux-kernel@vger.kernel.org List" , Alexander Graf , Blue Swirl , =?ISO-8859-1?Q?Am=E9rico_Wang?= , Ingo Molnar , Linus Torvalds Subject: Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels References: <1320543320-32728-1-git-send-email-agraf@suse.de> <4EB65C5B.8070709@redhat.com> <4EB66036.4080102@redhat.com> <1320577728.1428.73.camel@jaguar> <4EB67486.1070105@redhat.com> <4EB67D17.7000701@redhat.com> <4EB680D9.2070706@redhat.com> <877C82F4-F07C-44AA-8722-3AF57CFC4597@suse.de> <4EB7B1A9.9000409@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2011 12:30 PM, Sasha Levin wrote: > On Mon, Nov 7, 2011 at 12:23 PM, Gerd Hoffmann wrote: > > Hi, > > > >> It's not just about code, it's as much about culture and development process. > > > > Indeed. The BSDs have both kernel and the base system in a single > > repository. There are probably good reasons for (and against) it. > > > > In Linux we don't have that culture. No tool (except perf) lives in the > > kernel repo. I fail to see why kvm-tool is that much different from > > udev, util-linux, iproute, filesystem tools, that it should be included. > > tools/power was merged in just 2 versions ago, do you think that > merging that was a mistake? Things like tools/power may make sense, most of the code is tied to the kernel interfaces. tools/kvm is 20k lines and is likely to be 40k+ lines or more before it is generally usable. The proportion of the code that talks to the kernel is quite small. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: Add wrapper script around QEMU to test kernels Date: Mon, 07 Nov 2011 14:26:25 +0200 Message-ID: <4EB7CE71.50401@redhat.com> References: <1320543320-32728-1-git-send-email-agraf@suse.de> <4EB65C5B.8070709@redhat.com> <4EB66036.4080102@redhat.com> <1320577728.1428.73.camel@jaguar> <4EB67486.1070105@redhat.com> <4EB67D17.7000701@redhat.com> <4EB680D9.2070706@redhat.com> <877C82F4-F07C-44AA-8722-3AF57CFC4597@suse.de> <4EB7B1A9.9000409@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Blue Swirl , "kvm@vger.kernel.org list" , qemu-devel Developers , "linux-kernel@vger.kernel.org List" , Alexander Graf , Pekka Enberg , Gerd Hoffmann , =?ISO-8859-1?Q?Am=E9rico_Wang?= , Ingo Molnar , Linus Torvalds To: Sasha Levin Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org On 11/07/2011 12:30 PM, Sasha Levin wrote: > On Mon, Nov 7, 2011 at 12:23 PM, Gerd Hoffmann wrote: > > Hi, > > > >> It's not just about code, it's as much about culture and development process. > > > > Indeed. The BSDs have both kernel and the base system in a single > > repository. There are probably good reasons for (and against) it. > > > > In Linux we don't have that culture. No tool (except perf) lives in the > > kernel repo. I fail to see why kvm-tool is that much different from > > udev, util-linux, iproute, filesystem tools, that it should be included. > > tools/power was merged in just 2 versions ago, do you think that > merging that was a mistake? Things like tools/power may make sense, most of the code is tied to the kernel interfaces. tools/kvm is 20k lines and is likely to be 40k+ lines or more before it is generally usable. The proportion of the code that talks to the kernel is quite small. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNOHo-0004oP-SG for qemu-devel@nongnu.org; Mon, 07 Nov 2011 07:26:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNOHn-0002Ml-HT for qemu-devel@nongnu.org; Mon, 07 Nov 2011 07:26:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNOHn-0002MK-AU for qemu-devel@nongnu.org; Mon, 07 Nov 2011 07:26:47 -0500 Message-ID: <4EB7CE71.50401@redhat.com> Date: Mon, 07 Nov 2011 14:26:25 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1320543320-32728-1-git-send-email-agraf@suse.de> <4EB65C5B.8070709@redhat.com> <4EB66036.4080102@redhat.com> <1320577728.1428.73.camel@jaguar> <4EB67486.1070105@redhat.com> <4EB67D17.7000701@redhat.com> <4EB680D9.2070706@redhat.com> <877C82F4-F07C-44AA-8722-3AF57CFC4597@suse.de> <4EB7B1A9.9000409@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sasha Levin Cc: Blue Swirl , "kvm@vger.kernel.org list" , qemu-devel Developers , "linux-kernel@vger.kernel.org List" , Alexander Graf , Pekka Enberg , Gerd Hoffmann , =?ISO-8859-1?Q?Am=E9rico_Wang?= , Ingo Molnar , Linus Torvalds On 11/07/2011 12:30 PM, Sasha Levin wrote: > On Mon, Nov 7, 2011 at 12:23 PM, Gerd Hoffmann wrote: > > Hi, > > > >> It's not just about code, it's as much about culture and development process. > > > > Indeed. The BSDs have both kernel and the base system in a single > > repository. There are probably good reasons for (and against) it. > > > > In Linux we don't have that culture. No tool (except perf) lives in the > > kernel repo. I fail to see why kvm-tool is that much different from > > udev, util-linux, iproute, filesystem tools, that it should be included. > > tools/power was merged in just 2 versions ago, do you think that > merging that was a mistake? Things like tools/power may make sense, most of the code is tied to the kernel interfaces. tools/kvm is 20k lines and is likely to be 40k+ lines or more before it is generally usable. The proportion of the code that talks to the kernel is quite small. -- error compiling committee.c: too many arguments to function