From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:44061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Rc0JR-0006kA-3O
	for qemu-devel@nongnu.org; Sat, 17 Dec 2011 14:52:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Rc0JP-0004XB-Ko
	for qemu-devel@nongnu.org; Sat, 17 Dec 2011 14:52:53 -0500
Message-ID: <4EECF30E.9060109@web.de>
Date: Sat, 17 Dec 2011 20:52:46 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <alpine.DEB.2.02.1112170420460.22177@tyger.mit.edu>
In-Reply-To: <alpine.DEB.2.02.1112170420460.22177@tyger.mit.edu>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig92CCAABE478684B46E840052"
Subject: Re: [Qemu-devel] [PATCH] slirp: Fix typo in net_slirp_hostfwd_remove
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Geoffrey Thomas <geofft@ldpreload.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig92CCAABE478684B46E840052
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On 2011-12-17 10:23, Geoffrey Thomas wrote:
> Report an error when err is nonzero, not when it is zero.
>=20
> Signed-off-by: Geoffrey Thomas <geofft@ldpreload.com>
> ---
>  net/slirp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/net/slirp.c b/net/slirp.c
> index 6646ecb..18e07ba 100644
> --- a/net/slirp.c
> +++ b/net/slirp.c
> @@ -351,7 +351,7 @@ void net_slirp_hostfwd_remove(Monitor *mon, const
> QDict *qdict)
>                                 host_addr, host_port);
>=20
>      monitor_printf(mon, "host forwarding rule for %s %s\n", src_str,
> -                   err ? "removed" : "not found");
> +                   err ? "not found" : "removed");
>      return;
>=20
>   fail_syntax:

Oops, obviously. Stefan, should be another trivial one for you.

Thanks,
Jan


--------------enig92CCAABE478684B46E840052
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk7s8w4ACgkQitSsb3rl5xQswACfYyGpdStqmdspLOBfokU9rsIe
0cYAn0qsA/uWZ6fbv0j1m/EgSVbxD/UG
=MalQ
-----END PGP SIGNATURE-----

--------------enig92CCAABE478684B46E840052--