From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752739Ab1LSNDy (ORCPT ); Mon, 19 Dec 2011 08:03:54 -0500 Received: from mail-fx0-f46.google.com ([209.85.161.46]:51757 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752326Ab1LSNDx (ORCPT ); Mon, 19 Dec 2011 08:03:53 -0500 Message-ID: <4EEF35FB.9090707@mvista.com> Date: Mon, 19 Dec 2011 17:02:51 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: Felipe Balbi CC: Linux USB Mailing List , "Greg Kroah-Hartman (supporter:USB SUBSYSTEM ,commit_signer:28/50=56%)" , "Thomas Dahlmann (supporter:AMD GEODE CS5536...)" , "Kuninori Morimoto (commit_signer:43/50=86%)" , "open list:DESIGNWARE USB3 D..." , open list , "open list:AMD GEODE CS5536..." Subject: Re: [PATCH 9/9] usb: gadget: goku: use generic map/unmap routines References: <1324290632-23758-1-git-send-email-balbi@ti.com> <1324290632-23758-10-git-send-email-balbi@ti.com> In-Reply-To: <1324290632-23758-10-git-send-email-balbi@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 19-12-2011 14:30, Felipe Balbi wrote: > those routines have everything we need to map/unmap > USB requests and it's better to use them. > Signed-off-by: Felipe Balbi > --- > drivers/usb/gadget/goku_udc.c | 17 +++++++---------- > 1 files changed, 7 insertions(+), 10 deletions(-) > diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c > index 5af70fcc..bc47735 100644 > --- a/drivers/usb/gadget/goku_udc.c > +++ b/drivers/usb/gadget/goku_udc.c [...] > @@ -736,10 +732,11 @@ goku_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags) > return -EBUSY; > > /* set up dma mapping in case the caller didn't */ > - if (ep->dma&& _req->dma == DMA_ADDR_INVALID) { > - _req->dma = pci_map_single(dev->pdev, _req->buf, _req->length, > - ep->is_in ? PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE); > - req->mapped = 1; > + if (ep->dma) { > + status = usb_gadget_map_request(&dev->gadget, &req->req, Not '&_req->req'? WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 9/9] usb: gadget: goku: use generic map/unmap routines Date: Mon, 19 Dec 2011 17:02:51 +0400 Message-ID: <4EEF35FB.9090707@mvista.com> References: <1324290632-23758-1-git-send-email-balbi@ti.com> <1324290632-23758-10-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1324290632-23758-10-git-send-email-balbi-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Felipe Balbi Cc: Linux USB Mailing List , "Greg Kroah-Hartman (supporter:USB SUBSYSTEM ,commit_signer:28/50=56%)" , "Thomas Dahlmann (supporter:AMD GEODE CS5536...)" , "Kuninori Morimoto (commit_signer:43/50=86%)" , "open list:DESIGNWARE USB3 D..." , open list , "open list:AMD GEODE CS5536..." List-Id: linux-omap@vger.kernel.org Hello. On 19-12-2011 14:30, Felipe Balbi wrote: > those routines have everything we need to map/unmap > USB requests and it's better to use them. > Signed-off-by: Felipe Balbi > --- > drivers/usb/gadget/goku_udc.c | 17 +++++++---------- > 1 files changed, 7 insertions(+), 10 deletions(-) > diff --git a/drivers/usb/gadget/goku_udc.c b/drivers/usb/gadget/goku_udc.c > index 5af70fcc..bc47735 100644 > --- a/drivers/usb/gadget/goku_udc.c > +++ b/drivers/usb/gadget/goku_udc.c [...] > @@ -736,10 +732,11 @@ goku_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags) > return -EBUSY; > > /* set up dma mapping in case the caller didn't */ > - if (ep->dma&& _req->dma == DMA_ADDR_INVALID) { > - _req->dma = pci_map_single(dev->pdev, _req->buf, _req->length, > - ep->is_in ? PCI_DMA_TODEVICE : PCI_DMA_FROMDEVICE); > - req->mapped = 1; > + if (ep->dma) { > + status = usb_gadget_map_request(&dev->gadget, &req->req, Not '&_req->req'? WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html