From: Daniel Mack <zonque@gmail.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Takashi Iwai <tiwai@suse.de>,
blablack@gmail.com, alsa-devel@alsa-project.org,
gdiffey@gmail.com, linuxaudio@showlabor.de
Subject: Re: [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model
Date: Tue, 20 Dec 2011 21:16:56 +0100 [thread overview]
Message-ID: <4EF0ED38.5010306@gmail.com> (raw)
In-Reply-To: <4EF0AA75.10404@ladisch.de>
On 12/20/2011 04:32 PM, Clemens Ladisch wrote:
> Takashi Iwai wrote:
>> One point I'm not sure about this implementation is the use of
>> tasklet. The tasklet itself runs again in ep->lock, what's the
>> rationale for it? In other words, can't it be a straight function
>> call?
>
> This architecture was copied from ua101.c.
Yes.
> If I remember correctly,
> the original reason for the tasklet was to avoid calling
> snd_pcm_period_elapsed() from inside the lock. This would not be
> necessary in endpoint.c.
Hmm. It was actually you who told me to use a tasklet and not to submit
urbs from the input urb completion callbacks, as we can run out of
queuable playback buffers otherwise. Now that I think about it again, I
agree that it could be done without a tasklet as well by just keeping
the returned ones in a list and handle them in one go whenever possible.
I'll try this when I spin the next version.
Thanks,
Daniel
next prev parent reply other threads:[~2011-12-20 20:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 9:48 [PATCH 0/5] snd-usb endpoint rework, take 4 Daniel Mack
2011-12-20 9:48 ` [PATCH 1/5] ALSA: snd-usb: add snd_usb_audio-wide mutex Daniel Mack
2011-12-20 9:48 ` [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
2011-12-20 15:08 ` Takashi Iwai
2011-12-20 15:32 ` Clemens Ladisch
2011-12-20 20:16 ` Daniel Mack [this message]
2011-12-20 15:42 ` Takashi Iwai
2011-12-20 20:08 ` Daniel Mack
2011-12-20 9:48 ` [PATCH 3/5] ALSA: snd-usb: switch over to new endpoint streaming logic Daniel Mack
2011-12-20 9:48 ` [PATCH 4/5] ALSA: snd-usb: remove old " Daniel Mack
2011-12-20 9:48 ` [PATCH 5/5] ALSA: snd-usb: add support for implicit feedback Daniel Mack
-- strict thread matches above, loose matches on Subject: below --
2011-12-20 23:34 [PATCH 0/5] snd-usb endpoint rework, take 5 Daniel Mack
2011-12-20 23:34 ` [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
2011-12-21 16:16 ` Aurélien Leblond
2011-12-21 16:34 ` Daniel Mack
2011-12-21 17:11 ` Aurélien Leblond
2011-12-21 17:18 ` Daniel Mack
2011-12-22 17:55 ` Aurélien Leblond
2011-12-22 19:04 ` Daniel Mack
2011-12-18 23:02 [PATCH 0/5] snd-usb endpoint logic rework, version 3 Daniel Mack
2011-12-18 23:02 ` [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
2011-11-18 20:05 [PATCH 0/5] RFC v2 for snd-usb endpoint logic rework Daniel Mack
2011-11-18 20:05 ` [PATCH 2/5] ALSA: snd-usb: implement new endpoint streaming model Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF0ED38.5010306@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=blablack@gmail.com \
--cc=clemens@ladisch.de \
--cc=gdiffey@gmail.com \
--cc=linuxaudio@showlabor.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.