All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/1] [RESEND]Create a script for SUMMARY audit in recipes
Date: Wed, 21 Dec 2011 12:59:05 -0600	[thread overview]
Message-ID: <4EF22C79.7080906@windriver.com> (raw)
In-Reply-To: <4EF228C9.6070606@linux.intel.com>

On 12/21/11 12:43 PM, Saul Wold wrote:
> On 12/21/2011 10:16 AM, Joshua Lock wrote:
>> On 20/12/11 22:10, Wang, Shane wrote:
>>> Saul Wold wrote on 2011-12-21:
>>>
>>>> On 12/20/2011 08:32 PM, Shane Wang wrote:
>>>>> Here is the script to check which recipe provides SUMMARY and which
>>>>> doesnot. For those which do not, maintainer should add or update to a
>>>>> meaningful summary for HOB to display in description.
>>>>>
>>>> Shane,
>>>>
>>>> I guess I am not understanding why this is needed.  Why can't we use
>>>> DESCRIPTION which is a required entry?  Use the first X Characters of
>>>> DESCRIPTION?
>>
>> There's a huge difference between a purposefully crafted 72 character
>> summary and a free-for all description field that will have to be
>> chopped to be displayed in the GUI. I originally chose summary as a
>> succinct 72 characters would fit much better in the available UI.
>>
>> Aside: according to the Yocto docs the SUMMARY field should fall back to
>> DESCRIPTION anyway. It's just that right now we do that at the package
>> back-end level for each package back-end.
>>
> Seems that's the other way around as coded, DESCRIPTION falls back to
> SUMMARY
>
> meta/conf/bitbake.conf:DESCRIPTION ?= "${SUMMARY}"

Ya, I believe the original work was the reverse.. SUMMARY was the first X number 
of characters from the DESCRIPTION, but that soon changed..

Then the next iteration, all of the descriptions become summary fields and 
DESCRIPTION inherited SUMMARY.

And then a default SUMMARY was added to maintain compatibility with older OE 
recipes.

> Which is why I think this issue is cropping up. So, then the proposal
> should really be to add SUMMARY to all recipes and initially make it a
> warning for now if non-existent SUMMARY as with DESCRIPTION and then
> remove the existing SUMMARY = ${PN}-${PV} ...??
>
> The audit would then be the list of warnings which later becomes error

I agree, this should become some kind of an audit warning, so we can improve the 
quality of the recipe information.  I'm not sure I want it to be an error though 
as it may impact folks with existing OE recipes...

--Mark

> Sau!
>
>>
>>> OK, then HOB has a bug. To use DESCRIPTION instead of SUMMARY. I am OK with that.
>>> Josh, Dongxiao, did you see any problem if I change that?
>>
>> I think it's the wrong solution.
>>
>> Joshua
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core




  reply	other threads:[~2011-12-21 19:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-21  4:32 [PATCH 0/1] [RESEND]Create a script for SUMMARY audit in recipes Shane Wang
2011-12-21  4:32 ` [PATCH 1/1] Create " Shane Wang
2011-12-21  5:45 ` [PATCH 0/1] [RESEND]Create " Saul Wold
2011-12-21  6:10   ` Wang, Shane
2011-12-21 18:16     ` Joshua Lock
2011-12-21 18:43       ` Saul Wold
2011-12-21 18:59         ` Mark Hatle [this message]
2011-12-22 10:17           ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EF22C79.7080906@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.