From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:9003 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753976Ab1LVImM (ORCPT ); Thu, 22 Dec 2011 03:42:12 -0500 Message-ID: <4EF2ECA0.2080501@qca.qualcomm.com> (sfid-20111222_094220_048454_05D1E988) Date: Thu, 22 Dec 2011 10:38:56 +0200 From: Kalle Valo MIME-Version: 1.0 To: Stephen Rothwell CC: "John W. Linville" , Michal Marek , , , Rusty Russell , linux-wireless , ath6kl-devel Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related) References: <20111222165849.df5ea3e2997375de24f1490b@canb.auug.org.au> In-Reply-To: <20111222165849.df5ea3e2997375de24f1490b@canb.auug.org.au> Content-Type: text/plain; charset="ISO-8859-1" Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Stephen, I'll add linux-wireless and ath6kl-devel as I'm sick today and hopefully someone else from our team will take a look at it. On 12/22/2011 07:58 AM, Stephen Rothwell wrote: > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) > drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant > drivers/net/wireless/ath/ath6kl/init.c:32:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/init.c:32:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) > drivers/net/wireless/ath/ath6kl/init.c:32:1: error: expected ',' or ';' before string constant > drivers/net/wireless/ath/ath6kl/init.c:33:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/init.c:33:1: error: invalid initializer > drivers/net/wireless/ath/ath6kl/init.c:33:1: error: expected ',' or ';' before string constant > drivers/net/wireless/ath/ath6kl/init.c:34:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/init.c:34:1: error: invalid initializer > drivers/net/wireless/ath/ath6kl/init.c:34:1: error: expected ',' or ';' before string constant > > I can't figure out what goes wrong here. On the compile command line, > KBUILD_MODNAME is not defined, but KBUILD_BASE_NAME is. > > However, reverting commit fde57764ef87 ("ath6kl: enable USB support") > made the problem go away. That commit caused the above two files to be > built into two separate modules. Is this ppc specific problem? Is there anything we should do on ath6kl to fix this? Kalle From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related) Date: Thu, 22 Dec 2011 10:38:56 +0200 Message-ID: <4EF2ECA0.2080501@qca.qualcomm.com> References: <20111222165849.df5ea3e2997375de24f1490b@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:9003 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753976Ab1LVImM (ORCPT ); Thu, 22 Dec 2011 03:42:12 -0500 In-Reply-To: <20111222165849.df5ea3e2997375de24f1490b@canb.auug.org.au> Sender: linux-next-owner@vger.kernel.org List-ID: To: Stephen Rothwell Cc: "John W. Linville" , Michal Marek , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Rusty Russell , linux-wireless , ath6kl-devel Hi Stephen, I'll add linux-wireless and ath6kl-devel as I'm sick today and hopefully someone else from our team will take a look at it. On 12/22/2011 07:58 AM, Stephen Rothwell wrote: > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) > drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ',' or ';' before string constant > drivers/net/wireless/ath/ath6kl/init.c:32:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/init.c:32:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) > drivers/net/wireless/ath/ath6kl/init.c:32:1: error: expected ',' or ';' before string constant > drivers/net/wireless/ath/ath6kl/init.c:33:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/init.c:33:1: error: invalid initializer > drivers/net/wireless/ath/ath6kl/init.c:33:1: error: expected ',' or ';' before string constant > drivers/net/wireless/ath/ath6kl/init.c:34:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/init.c:34:1: error: invalid initializer > drivers/net/wireless/ath/ath6kl/init.c:34:1: error: expected ',' or ';' before string constant > > I can't figure out what goes wrong here. On the compile command line, > KBUILD_MODNAME is not defined, but KBUILD_BASE_NAME is. > > However, reverting commit fde57764ef87 ("ath6kl: enable USB support") > made the problem go away. That commit caused the above two files to be > built into two separate modules. Is this ppc specific problem? Is there anything we should do on ath6kl to fix this? Kalle