From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755280Ab1LVQzr (ORCPT ); Thu, 22 Dec 2011 11:55:47 -0500 Received: from cantor2.suse.de ([195.135.220.15]:34963 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751411Ab1LVQzp (ORCPT ); Thu, 22 Dec 2011 11:55:45 -0500 Message-ID: <4EF3616D.5050506@suse.cz> Date: Thu, 22 Dec 2011 17:57:17 +0100 From: Michal Marek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Stephen Rothwell , Kalle Valo Cc: "John W. Linville" , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Rusty Russell Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related) References: <20111222165849.df5ea3e2997375de24f1490b@canb.auug.org.au> In-Reply-To: <20111222165849.df5ea3e2997375de24f1490b@canb.auug.org.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne 22.12.2011 06:58, Stephen Rothwell napsal(a): > Hi , > > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' > drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) [...] > > I can't figure out what goes wrong here. On the compile command line, > KBUILD_MODNAME is not defined, but KBUILD_BASE_NAME is. scripts/Makefile.lib says # Note: It's possible that one object gets potentially linked into more # than one module. In that case KBUILD_MODNAME will be set to foo_bar, # where foo and bar are the name of the modules. but reality does not match this comment: modname_flags = $(if $(filter 1,$(words $(modname))),\ -D"KBUILD_MODNAME=KBUILD_STR($(call name-fix,$(modname)))") But I wonder why you need to link all the object files twice? Usually, drivers have a foo_common.ko and foo_{usb,pci,whatever}.ko that provide the pci/usb/whatever driver. Michal