From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754630Ab1LXB0d (ORCPT ); Fri, 23 Dec 2011 20:26:33 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:27014 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982Ab1LXB0a (ORCPT ); Fri, 23 Dec 2011 20:26:30 -0500 X-IronPort-AV: E=McAfee;i="5400,1158,6569"; a="149666651" X-IronPort-AV: E=Sophos;i="4.71,399,1320652800"; d="scan'208";a="151785784" Message-ID: <4EF52A34.70409@qca.qualcomm.com> Date: Sat, 24 Dec 2011 03:26:12 +0200 From: Kalle Valo User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110922 Thunderbird/3.1.15 MIME-Version: 1.0 To: Michal Marek CC: Stephen Rothwell , "John W. Linville" , , , Rusty Russell Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related) References: <20111222165849.df5ea3e2997375de24f1490b@canb.auug.org.au> <4EF3616D.5050506@suse.cz> In-Reply-To: <4EF3616D.5050506@suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.64.10.226] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2011 06:57 PM, Michal Marek wrote: > Dne 22.12.2011 06:58, Stephen Rothwell napsal(a): >> Hi , >> >> After merging the final tree, today's linux-next build (powerpc >> allyesconfig) failed like this: >> >> drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' >> drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) > [...] >> >> I can't figure out what goes wrong here. On the compile command line, >> KBUILD_MODNAME is not defined, but KBUILD_BASE_NAME is. > > scripts/Makefile.lib says > # Note: It's possible that one object gets potentially linked into more > # than one module. In that case KBUILD_MODNAME will be set to foo_bar, > # where foo and bar are the name of the modules. > > but reality does not match this comment: > modname_flags = $(if $(filter 1,$(words $(modname))),\ > -D"KBUILD_MODNAME=KBUILD_STR($(call name-fix,$(modname)))") > > But I wonder why you need to link all the object files twice? No particular reason. I just didn't know that it's not allowed. > Usually, drivers have a foo_common.ko and foo_{usb,pci,whatever}.ko that provide > the pci/usb/whatever driver. I have been planning to do the same for ath6kl. I just need to do a bit of interface cleanup before I can cleanly separate the core module. I'll start looking at that next. Kalle From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: linux-next: build failure after merge of the final tree (wireless tree related) Date: Sat, 24 Dec 2011 03:26:12 +0200 Message-ID: <4EF52A34.70409@qca.qualcomm.com> References: <20111222165849.df5ea3e2997375de24f1490b@canb.auug.org.au> <4EF3616D.5050506@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:27014 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982Ab1LXB0a (ORCPT ); Fri, 23 Dec 2011 20:26:30 -0500 In-Reply-To: <4EF3616D.5050506@suse.cz> Sender: linux-next-owner@vger.kernel.org List-ID: To: Michal Marek Cc: Stephen Rothwell , "John W. Linville" , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Rusty Russell On 12/22/2011 06:57 PM, Michal Marek wrote: > Dne 22.12.2011 06:58, Stephen Rothwell napsal(a): >> Hi , >> >> After merging the final tree, today's linux-next build (powerpc >> allyesconfig) failed like this: >> >> drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: expected ')' before 'KBUILD_MODNAME' >> drivers/net/wireless/ath/ath6kl/cfg80211.c:27:1: error: 'KBUILD_MODNAME' undeclared here (not in a function) > [...] >> >> I can't figure out what goes wrong here. On the compile command line, >> KBUILD_MODNAME is not defined, but KBUILD_BASE_NAME is. > > scripts/Makefile.lib says > # Note: It's possible that one object gets potentially linked into more > # than one module. In that case KBUILD_MODNAME will be set to foo_bar, > # where foo and bar are the name of the modules. > > but reality does not match this comment: > modname_flags = $(if $(filter 1,$(words $(modname))),\ > -D"KBUILD_MODNAME=KBUILD_STR($(call name-fix,$(modname)))") > > But I wonder why you need to link all the object files twice? No particular reason. I just didn't know that it's not allowed. > Usually, drivers have a foo_common.ko and foo_{usb,pci,whatever}.ko that provide > the pci/usb/whatever driver. I have been planning to do the same for ath6kl. I just need to do a bit of interface cleanup before I can cleanly separate the core module. I'll start looking at that next. Kalle