From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39444)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RirOg-0000uj-7U
	for qemu-devel@nongnu.org; Thu, 05 Jan 2012 12:46:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RirOd-0004y5-Ne
	for qemu-devel@nongnu.org; Thu, 05 Jan 2012 12:46:38 -0500
Received: from cantor2.suse.de ([195.135.220.15]:49777 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RirOd-0004y1-Fv
	for qemu-devel@nongnu.org; Thu, 05 Jan 2012 12:46:35 -0500
Message-ID: <4F05E1A1.5050709@suse.de>
Date: Thu, 05 Jan 2012 18:45:05 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <CAAu8pHvdTudV1zKoVmX4hNDJw-Kjq5zcosnN3MnD9H3sGeYMdw@mail.gmail.com>
In-Reply-To: <CAAu8pHvdTudV1zKoVmX4hNDJw-Kjq5zcosnN3MnD9H3sGeYMdw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/2] m48t59: drop obsolete address base
	arithmetic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>

Am 15.10.2011 15:50, schrieb Blue Swirl:
> Remove now incorrect address base arithmetic, missed by
> 9936d6e42392f1440505dfa9df065eabd251cadf. Fixes Sparc64 boot.

...but breaks PReP boot:

ERROR: BUG caught...
BIOS execution exception
nip=3D0x05800000 msr=3D0x00002000 dar=3D0x00000000 dsisr=3D0x00000000
Stopping execution

I verified by checking out the preceding commit, applying a variation of
http://patchwork.ozlabs.org/patch/134519/ on top; that restored PReP
boot to what it used to look like.

Any insights?

If I revert this commit on HEAD instead, then the above error
disappears, too, but there's another regression with the kernel not
being able to read the hda or something.

The write access fix seems unrelated.

Andreas

> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  hw/m48t59.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
>=20
> diff --git a/hw/m48t59.c b/hw/m48t59.c
> index f318e67..dba5796 100644
> --- a/hw/m48t59.c
> +++ b/hw/m48t59.c
> @@ -480,7 +480,6 @@ static void NVRAM_writeb (void *opaque, uint32_t
> addr, uint32_t val)
>  {
>      M48t59State *NVRAM =3D opaque;
>=20
> -    addr -=3D NVRAM->io_base;
>      NVRAM_PRINTF("%s: 0x%08x =3D> 0x%08x\n", __func__, addr, val);
>      switch (addr) {
>      case 0:
> @@ -505,7 +504,6 @@ static uint32_t NVRAM_readb (void *opaque, uint32_t=
 addr)
>      M48t59State *NVRAM =3D opaque;
>      uint32_t retval;
>=20
> -    addr -=3D NVRAM->io_base;
>      switch (addr) {
>      case 3:
>          retval =3D m48t59_read(NVRAM, NVRAM->addr);

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg