From: Saul Wold <sgw@linux.intel.com>
To: Derek Buitenhuis <derek.buitenhuis@gmail.com>
Cc: poky@yoctoproject.org
Subject: Re: [PATCH 2/2] binutils: Allow plugins
Date: Fri, 06 Jan 2012 14:31:58 -0800 [thread overview]
Message-ID: <4F07765E.6050001@linux.intel.com> (raw)
In-Reply-To: <1325640237-17019-2-git-send-email-derek.buitenhuis@gmail.com>
On 01/03/2012 05:23 PM, Derek Buitenhuis wrote:
> Make sure it's possible to build binutils with
> plugin support.
>
> Signed-off-by: Derek Buitenhuis<derek.buitenhuis@gmail.com>
> ---
> .../binutils/binutils-cross-canadian.inc | 3 ++-
> meta/recipes-devtools/binutils/binutils-cross.inc | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> index 00648a6..4f20ad7 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> +++ b/meta/recipes-devtools/binutils/binutils-cross-canadian.inc
> @@ -8,7 +8,8 @@ DEPENDS = "flex-native bison-native virtual/${HOST_PREFIX}gcc-crosssdk virtual/l
> EXTRA_OECONF = "--with-sysroot=${SDKPATH}/sysroots/${TUNE_PKGARCH}${TARGET_VENDOR}-${TARGET_OS} \
> --program-prefix=${TARGET_PREFIX} \
> --disable-werror \
> - ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)}"
> + ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
>
> do_install () {
> autotools_do_install
> diff --git a/meta/recipes-devtools/binutils/binutils-cross.inc b/meta/recipes-devtools/binutils/binutils-cross.inc
> index 80152a9..0af913d 100644
> --- a/meta/recipes-devtools/binutils/binutils-cross.inc
> +++ b/meta/recipes-devtools/binutils/binutils-cross.inc
> @@ -10,7 +10,8 @@ EXTRA_OECONF = "--with-sysroot=${STAGING_DIR_TARGET} \
> --disable-werror \
> --enable-poison-system-directories \
> ${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-gold=default', '', d)} \
> - ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)}"
> + ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
> + ${@base_contains('DISTRO_FEATURES', 'binutils-plugins', '--enable-plugins', '', d)}"
>
> do_install () {
> oe_runmake 'DESTDIR=${D}' install
I think that the DISTRO_FEATURE here is too much, you this be changed to
be a PACKAGECONFIG instead?
Sau!
next prev parent reply other threads:[~2012-01-06 22:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 1:23 [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Derek Buitenhuis
2012-01-04 1:23 ` [PATCH 2/2] binutils: Allow plugins Derek Buitenhuis
2012-01-06 21:48 ` Derek Buitenhuis
2012-01-06 22:31 ` Saul Wold [this message]
2012-01-21 22:58 ` Khem Raj
2012-01-22 18:41 ` Derek Buitenhuis
2012-01-05 20:15 ` [PATCH 1/2] binutils-cross-canadian: Allow ld-is-gold Saul Wold
2012-01-05 20:33 ` Derek Buitenhuis
2012-01-22 18:41 ` [PATCH 2/2 v2] binutils: Always enable plugins Derek Buitenhuis
2012-01-22 18:57 ` Khem Raj
2012-01-22 19:01 ` Derek Buitenhuis
2012-01-22 19:05 ` Khem Raj
2012-02-02 2:08 ` Derek Buitenhuis
2012-02-02 5:04 ` Khem Raj
2012-04-29 17:56 ` Derek Buitenhuis
2012-04-30 14:36 ` Saul Wold
2012-04-30 15:52 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F07765E.6050001@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=derek.buitenhuis@gmail.com \
--cc=poky@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.