From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Andreas_Bie=DFmann?= <andreas.devel@googlemail.com>
Date: Mon, 09 Jan 2012 12:21:57 +0100
Subject: [U-Boot] [RFC PATCH 01/19] Introduce generic global_data
In-Reply-To: <CAPnjgZ2vbV2CG_9e1CjCO80LySYOQML5ELYKdu4KAN_xytWVyA@mail.gmail.com>
References: <1325054160-24894-1-git-send-email-sjg@chromium.org>
	<1325054160-24894-2-git-send-email-sjg@chromium.org>
	<4EFC1B02.1070607@googlemail.com>
	<CAPnjgZ0H3JHkTFNRxt-TXqGhSixo+a3J2ACGSktirZqLVDNXnQ@mail.gmail.com>
	<4F097476.9090803@gmail.com>
	<CAPnjgZ2vbV2CG_9e1CjCO80LySYOQML5ELYKdu4KAN_xytWVyA@mail.gmail.com>
Message-ID: <4F0ACDD5.4050406@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon and Graeme,

On 08.01.2012 19:13, Simon Glass wrote:
> Hi Graeme,
> 
> On Sun, Jan 8, 2012 at 2:48 AM, Graeme Russ <graeme.russ@gmail.com> wrote:
>> Hi Simon,
>>
>> On 08/01/12 09:33, Simon Glass wrote:
>>> Hi Andreas,
>>>
>>> On Wed, Dec 28, 2011 at 11:47 PM, Andreas Bie?mann
>>> <andreas.devel@googlemail.com> wrote:
>>>> Dear Simon,
>>>>
>>>> On 28.12.11 07:35, Simon Glass wrote:

<snip discussion about 'how to restructure gd_t' ... should be done later>

>>> For now I would prefer to do nothing on either point, since bringing
>>> everything into one place shows up the conflicts and similarities.
>>> Part of the purpose of the generic board effort is to minimise these,
>>> and they are hard to spot if they are all in separate files.

Currently I agree with you both. It would be best to just move all the
specific stuff into one file but let the structure as is (from view of
SoC/arch). Later on we could shrink it down by one of the mentioned
possibilities.

>> Hmm, I'm starting to wonder if we should instead have:
>>
>> struct gd_generic {
>>        /* Relocation stuff */
>>
>>        /* pre-console stuff */
>>
>>        /* Jump table stuff */
>> }
>>
>> struct gd {
>>        struct gd_generic common;
>>
>>        /* Arch specific stuff */
>> }
>>
>> This eliminates the 'no arch specific global data' corner case

Sounds good to me, but if we restructure gd_t in any way we should
introduce some ability to version the struct for future changes (keep
stand alone apps in mind!).

best regards

Andreas Bie?mann