From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Tue, 10 Jan 2012 11:40:32 -0700 Subject: [U-Boot] [PATCH 12/14] tegra: Set vdd_core and vdd_cpu to high In-Reply-To: <1324927987-13100-13-git-send-email-sjg@chromium.org> References: <1324927987-13100-1-git-send-email-sjg@chromium.org> <1324927987-13100-13-git-send-email-sjg@chromium.org> Message-ID: <4F0C8620.2060003@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/26/2011 12:33 PM, Simon Glass wrote: > From: Jimmy Zhang > > At cold boot, the default voltage supplied by pmu is not high enough > to support emc to run at its highest clock frequency. The code added > here is to update the default vdd_core and vdd_cpu to higher values. > > (Sorry if I have mangled this comment) ?? Remove that last line? I thought this issue only affected the T25 SKU when coupled with a particular voltage regulator that wasn't reprogrammed to explicitly support T25. Hence, shouldn't this code only be enabled for specific boards? > diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c ... > /* > + * Routine: power_det_init > + * Description: turn off power detects > + */ > +static void power_det_init(void) > +{ > +#if defined(CONFIG_TEGRA2) > + struct pmc_ctlr *const pmc = (struct pmc_ctlr *)TEGRA2_PMC_BASE; > + > + /* turn off power detects */ > + writel(0, &pmc->pmc_pwr_det_latch); > + writel(0, &pmc->pmc_pwr_det); > +#endif > +} I can't tell how that code relates to the commit description. -- nvpublic