From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?U3RlcGhhbiBCw6Ryd29sZg==?= Subject: Re: [PATCH 0/2] KVM guest-kernel panics double fault Date: Sun, 15 Jan 2012 20:44:50 +0100 Message-ID: <4F132CB2.3090007@tu-ilmenau.de> References: <4F0C3044.7050307@redhat.com> <4F0C33A0.6080509@tu-ilmenau.de> <4F0C4AA9.6000203@tu-ilmenau.de> <20120111190927.GA13298@amt.cnet> <4F0DEA86.90503@tu-ilmenau.de> <20120111212150.GA18948@amt.cnet> <4F0E0B06.2090708@tu-ilmenau.de> <20120112104756.GB31635@amt.cnet> <4F0EFF84.8020500@tu-ilmenau.de> <4F0F02B1.8080508@siemens.com> <20120113101325.GA25595@amt.cnet> Reply-To: stephan.baerwolf@tu-ilmenau.de Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Jan Kiszka , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from wega.rz.tu-ilmenau.de ([141.24.4.159]:58591 "EHLO wega.rz.tu-ilmenau.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778Ab2AOTqf (ORCPT ); Sun, 15 Jan 2012 14:46:35 -0500 In-Reply-To: <20120113101325.GA25595@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: Thank you for applying this, Marcelo. I fear we (or me after I agreed) did some mistake by erasing the additi= onal cpuid 0x80000001 checks. In contradiction to only AMD it MUST also apply on Intel-CPUs. Documentation "http://www.intel.com/content/dam/doc/manual/64-ia-32-architectures-sof= tware-developer-manual-325462.pdf" Vol. 2A 3-207 (PDF-page 811) first block of table. (in addition AMD's doku "http://support.amd.com/us/Processor_TechDocs/A= PM_V3_24594.pdf" page 376 (PDF-page 408) table "Exceptions" on the bottom) Not all CPUs might have a syscall op at all (even in longmode) - they i= nforming about that via cpuid (But MSR_EFER may be still set). (You can force it externally in qemu-kvm-emulation via "-cpu host,-sysc= all" ...) So an (guest) operating-system might not install *STAR-registers and cr= ash again on such vcpus, right? I'll prepare some patch, asap. So everybody can judge this... regards, Stephan On 01/13/12 11:13, Marcelo Tosatti wrote: > On Thu, Jan 12, 2012 at 04:56:33PM +0100, Jan Kiszka wrote: >>> Stephan Baerwolf (2): >>> KVM: extend "struct x86_emulate_ops" with "get_cpuid" >>> KVM: fix missing "illegal instruction"-trap in protected modes >>> >>> arch/x86/include/asm/kvm_emulate.h | 19 ++++++++ >>> arch/x86/kvm/emulate.c | 80 >>> ++++++++++++++++++++++++++++++++++- >>> arch/x86/kvm/x86.c | 21 +++++++++ >>> 3 files changed, 117 insertions(+), 3 deletions(-) >>> >> linux/scripts/checkpatch.pl can help identifying remaining style vio= lations. >> >> Moreover, when sending your patches via Thunderbird, you first need = to >> make sure that you have its line wrapping under control. "Toggle Wor= d >> Wrap" helps me for single patches. But for series, I prefer (scripte= d) >> git format-patch/send-email. > Applied a cleanup up version of these patches. Thanks Stephan. > > http://git.kernel.org/?p=3Dvirt/kvm/kvm.git;a=3Dcommit;h=3D0769c5de24= 621141c953fbe1f943582d37cb4244 > > http://git.kernel.org/?p=3Dvirt/kvm/kvm.git;a=3Dcommit;h=3De28ba7bb02= 0f07193bc000453c8775e9d2c0dda7 > > > --=20 Dipl.-Inf. Stephan B=C3=A4rwolf Ilmenau University of Technology, Integrated Communication Systems Grou= p Phone: +49 (0)3677 69 4130 Email: stephan.baerwolf@tu-ilmenau.de, =20 Web: http://www.tu-ilmenau.de/iks