Re: [PATCH PLACEHOLDER 1/3] fs/exec: "always_unprivileged" patch

[Casey Schaufler <casey@schaufler-ca.com>]

On 1/14/2012 12:22 PM, Linus Torvalds wrote:
> On Sat, Jan 14, 2012 at 5:30 AM, Jamie Lokier<jamie@shareable.org>  wrote:
>> Anyway the principle is there - CAP_NET_BIND doesn't necessarily mean
>> the daemon code is trusted.
> I really think all these arguments are *COMPLETELY* missing the point.
>
> You don't have to use the new flag if you don't want to. Just let it go.
>
> The point of the flag is to not allow security changes. It's that
> easy. If you want something else, don't use it.
>
> Because even "dropping capabilities" is quite often the wrong thing to
> do. To one person it's "dropping capabilities", to another it is "no
> longer running with the capabilities I need".
>
> We've had security bugs that were *due* to dropped capabilities -
> people dropped one capability but not another, and fooled code into
> doing things they weren't expecting it to do. So quite frankly, I
> believe that from a security standpoint it's a hell of a lot safer to
> just keep the rules really simple.
>
> Think of the "restrict" bit as "my universe will now run with this
> *known* set of permissions".
>
> And if you don't like it, don't use it. It really is that simple. But
> don't make the model more complicated. Don't confuse it with "but but
> capabilites" crap. The point of the patch is that it makes all of that
> go away. There are no capabilities. There only is what you can do.
>
> And yes, I really seriously do believe that is both safer and simpler
> than some model that says "you can drop stuff", and then you have to
> start making up rules for what "dropping" means.
>
> Does "dropping" mean allowing setuid(geteuid()) for example? That *is*
> dropping the uid in a _POSIX_SAVED_IDS environment. And I'm saying
> that no, we should not even allow that. It's simply all too "subtle".

I am casting my two cents worth behind Linus. Dropping
privilege can be every bit as dangerous as granting privilege
in the real world of atrocious user land code. Especially in
the case of security policy enforcing user land code.

This even more important in environments that support fine
granularity of privilege, including capabilities and SELinux.
Under SELinux a domain transition can increase, decrease or
completely change a process' access rights and there is really
no way for the kernel to tell which it is because that's all
encoded in the arbitrary SELinux policy. Smack does not try
to maintain a notion of hierarchy of privilege, so the notion
of any change being equivalent to any other is in line with
the Smack philosophy.

>
> (I don't think Andrew's patch actually touched any of those paths, but
> I didn't check)
>
>                        Linus
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>