All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stephan Bärwolf" <stephan.baerwolf@tu-ilmenau.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 0/2] KVM guest-kernel panics double fault
Date: Mon, 16 Jan 2012 12:24:17 +0100	[thread overview]
Message-ID: <4F1408E1.6010608@tu-ilmenau.de> (raw)
In-Reply-To: <20120116095809.GA7937@amt.cnet>

Okay, thx to hear a second opinion.

Then everything is ok, have a nice day.

regards Stephan

On 01/16/12 10:58, Marcelo Tosatti wrote:
> On Sun, Jan 15, 2012 at 08:44:50PM +0100, Stephan Bärwolf wrote:
>> Thank you for applying this, Marcelo.
>>
>> I fear we (or me after I agreed) did some mistake by erasing the additional
>> cpuid 0x80000001 checks.
>> In contradiction to only AMD it MUST also apply on Intel-CPUs.
>>
>> Documentation
>> "http://www.intel.com/content/dam/doc/manual/64-ia-32-architectures-software-developer-manual-325462.pdf"
>> Vol. 2A 3-207 (PDF-page 811) first block of table.
>> (in addition AMD's doku "http://support.amd.com/us/Processor_TechDocs/APM_V3_24594.pdf"
>> page 376 (PDF-page 408) table "Exceptions" on the bottom)
>>
>> Not all CPUs might have a syscall op at all (even in longmode) - they informing about that
>> via cpuid (But MSR_EFER may be still set).
>> (You can force it externally in qemu-kvm-emulation via "-cpu host,-syscall" ...)
>> So an (guest) operating-system might not install *STAR-registers and crash again on such vcpus, right?
> No because if the operating system does not install the STAR MSRs, it
> will not set SCE bit in MSR_EFER (and your patch handles that 
> situation).
>
>


-- 
Dipl.-Inf. Stephan Bärwolf
Ilmenau University of Technology, Integrated Communication Systems Group
Phone: +49 (0)3677 69 4130
Email: stephan.baerwolf@tu-ilmenau.de,  
Web: http://www.tu-ilmenau.de/iks


  reply	other threads:[~2012-01-16 11:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-29  1:59 KVM guest-kernel panics double fault Stephan Bärwolf
2011-12-29 10:04 ` Avi Kivity
2012-01-08  2:31   ` Stephan Bärwolf
2012-01-08 10:21     ` Avi Kivity
2012-01-10 10:11       ` Stephan Bärwolf
2012-01-10 10:31         ` Avi Kivity
2012-01-10 12:17           ` Stephan Bärwolf
2012-01-10 12:34             ` Avi Kivity
2012-01-10 12:48               ` Stephan Bärwolf
2012-01-10 14:26                 ` [PATCH 0/2] " Stephan Bärwolf
2012-01-10 14:26                 ` [PATCH 1/2] KVM: extend "struct x86_emulate_ops" with "get_cpuid" Stephan Bärwolf
2012-01-10 14:26                 ` [PATCH 2/2] KVM: fix missing "illegal instruction"-trap in protected modes Stephan Bärwolf
2012-01-11 19:09                   ` Marcelo Tosatti
2012-01-11 20:01                     ` Stephan Bärwolf
2012-01-11 21:21                       ` Marcelo Tosatti
2012-01-11 22:19                         ` Stephan Bärwolf
2012-01-12 10:47                           ` Marcelo Tosatti
2012-01-12 15:43                             ` [PATCH 0/2] KVM guest-kernel panics double fault Stephan Bärwolf
2012-01-12 15:56                               ` Jan Kiszka
2012-01-13 10:13                                 ` Marcelo Tosatti
2012-01-15 19:44                                   ` Stephan Bärwolf
2012-01-16  9:58                                     ` Marcelo Tosatti
2012-01-16 11:24                                       ` Stephan Bärwolf [this message]
2012-01-12 15:43                             ` [PATCH 1/2] KVM: extend "struct x86_emulate_ops" with "get_cpuid" Stephan Bärwolf
2012-01-12 15:43                             ` [PATCH 2/2] KVM: fix missing "illegal instruction"-trap in protected modes Stephan Bärwolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1408E1.6010608@tu-ilmenau.de \
    --to=stephan.baerwolf@tu-ilmenau.de \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.