All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3: TAM3517: update ehci interface
Date: Mon, 06 Feb 2012 16:55:29 +0200	[thread overview]
Message-ID: <4F2FE9E1.2070601@compulab.co.il> (raw)
In-Reply-To: <1328342869-13347-1-git-send-email-sbabic@denx.de>

Hi Stefano,

On 02/04/12 10:07, Stefano Babic wrote:
> Changed the EHCI interface using the ulpi framework.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Tom Rini <tom.rini@gmail.com>
> ---
> 
> This patch is based and tested on top of  Govindraj's patches for EHCI omap:
> 	http://patchwork.ozlabs.org/patch/139377/
> 
>  board/technexion/twister/twister.c |   32 ++++++++++++++++++++++++++++++++
>  include/configs/tam3517-common.h   |    2 ++
>  2 files changed, 34 insertions(+), 0 deletions(-)
> 
> diff --git a/board/technexion/twister/twister.c b/board/technexion/twister/twister.c
> index 4d34d24..831fb4c 100644
> --- a/board/technexion/twister/twister.c
> +++ b/board/technexion/twister/twister.c
> @@ -33,6 +33,10 @@
>  #include <asm/arch/mmc_host_def.h>
>  #include <i2c.h>
>  #include <asm/gpio.h>
> +#ifdef CONFIG_USB_EHCI
> +#include <usb.h>
> +#include <asm/ehci-omap.h>
> +#endif
>  #include "twister.h"
>  
>  DECLARE_GLOBAL_DATA_PTR;
> @@ -56,6 +60,34 @@ static const u32 gpmc_XR16L2751[] = {
>  	XR16L2751_GPMC_CONFIG6,
>  };
>  
> +#ifdef CONFIG_USB_EHCI
> +
> +static struct omap_usbhs_board_data usbhs_bdata = {
> +	.port_mode[0] = OMAP_EHCI_PORT_MODE_PHY,
> +	.port_mode[1] = OMAP_EHCI_PORT_MODE_PHY,
> +	.port_mode[2] = OMAP_EHCI_PORT_MODE_PHY,
> +};

OMAP EHCI port3 is TLL only, so the above does not look right...

> +
> +int ehci_hcd_init(void)
> +{
> +	int ret;
> +
> +	ret = omap_ehci_hcd_init(&usbhs_bdata);
> +	if (ret < 0)
> +		return ret;
> +
> +	return 0;
> +}

return omap_ehci_hcd_init(&usbhs_bdata);
?

> +
> +int ehci_hcd_stop(void)
> +{
> +	int ret;
> +
> +	ret = omap_ehci_hcd_stop();
> +	return ret;

return omap_ehci_hcd_stop();
?

> +}
> +#endif
> +
>  int board_init(void)
>  {
>  	gpmc_init(); /* in SRAM or SDRAM, finish GPMC */
> diff --git a/include/configs/tam3517-common.h b/include/configs/tam3517-common.h
> index 817d468..13eeadb 100644
> --- a/include/configs/tam3517-common.h
> +++ b/include/configs/tam3517-common.h
> @@ -100,6 +100,8 @@
>  #define CONFIG_OMAP3_GPIO_5
>  #define CONFIG_USB_EHCI
>  #define CONFIG_USB_EHCI_OMAP
> +#define CONFIG_USB_ULPI
> +#define CONFIG_USB_ULPI_VIEWPORT_OMAP
>  #define CONFIG_OMAP_EHCI_PHY1_RESET_GPIO	25
>  #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
>  #define CONFIG_USB_STORAGE

-- 
Regards,
Igor.

  reply	other threads:[~2012-02-06 14:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-04  8:07 [U-Boot] [PATCH] OMAP3: TAM3517: update ehci interface Stefano Babic
2012-02-06 14:55 ` Igor Grinberg [this message]
2012-02-07 15:13   ` Stefano Babic
2012-02-07 15:33     ` Stefano Babic
2012-02-08  6:06       ` Govindraj
2012-02-08  8:03         ` Stefano Babic
2012-02-08  9:28 ` [U-Boot] [PATCH V2] " Stefano Babic
2012-02-08 10:08   ` Igor Grinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F2FE9E1.2070601@compulab.co.il \
    --to=grinberg@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.