All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Kyoungil Kim <ki0351.kim@samsung.com>
Cc: spi-devel-general@lists.sourceforge.net,
	linux-samsung-soc@vger.kernel.org,
	'Grant Likely' <grant.likely@secretlab.ca>,
	'Kukjin Kim' <kgene.kim@samsung.com>
Subject: Re: [PATCH] spi: Add the use of DMA config operation
Date: Wed, 08 Feb 2012 11:05:33 +0100	[thread overview]
Message-ID: <4F3248ED.8030408@samsung.com> (raw)
In-Reply-To: <000401cce62e$3c0cd5e0$b42681a0$%kim@samsung.com>

Hi,

On 02/08/2012 07:52 AM, Kyoungil Kim wrote:
> Config operation is separated from request operation in DMA common operation.
> Because spi driver can change the DMA config for every message.
> So this patch is using the separated DMA config operation.
> 
> Signed-off-by: Boojin Kim <boojin.kim@samsung.com>
> Signed-off-by: Kyoungil Kim <ki0351.kim@samsung.com>
> ---
>  drivers/spi/spi-s3c64xx.c |   35 +++++++++++++++++++++--------------
>  1 files changed, 21 insertions(+), 14 deletions(-)

I'm getting following compilation errors with this patch:

  CC      drivers/spi/spi-s3c64xx.o
drivers/spi/spi-s3c64xx.c: In function ‘prepare_dma’:
drivers/spi/spi-s3c64xx.c:268: error: storage size of ‘info’ isn’t known
drivers/spi/spi-s3c64xx.c:269: error: storage size of ‘config’ isn’t known
drivers/spi/spi-s3c64xx.c:278: error: ‘struct samsung_dma_ops’ has no member
named ‘config’
drivers/spi/spi-s3c64xx.c:286: error: ‘struct samsung_dma_ops’ has no member
named ‘config’
drivers/spi/spi-s3c64xx.c:269: warning: unused variable ‘config’
drivers/spi/spi-s3c64xx.c:268: warning: unused variable ‘info’
drivers/spi/spi-s3c64xx.c: In function ‘acquire_dma’:
drivers/spi/spi-s3c64xx.c:302: error: storage size of ‘req’ isn’t known
drivers/spi/spi-s3c64xx.c:302: warning: unused variable ‘req’

Which tree has it been created off of ?

It seems there are some patches not yet in mainline that it depends on.


Thanks,
-- 
Sylwester Nawrocki
Samsung Poland R&D Center

  reply	other threads:[~2012-02-08 10:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-08  6:52 [PATCH] spi: Add the use of DMA config operation Kyoungil Kim
2012-02-08 10:05 ` Sylwester Nawrocki [this message]
2012-02-08 10:34   ` Kyoungil Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3248ED.8030408@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=ki0351.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.