From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39665)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rv9NE-0007iC-LI
	for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:24:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rv9ND-0007oi-C7
	for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:23:56 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:58591)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Rv9ND-0007l7-79
	for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:23:55 -0500
Received: by pbbro12 with SMTP id ro12so765660pbb.4
	for <qemu-devel@nongnu.org>; Wed, 08 Feb 2012 07:23:53 -0800 (PST)
Message-ID: <4F329385.4030203@codemonkey.ws>
Date: Wed, 08 Feb 2012 09:23:49 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4F324A60.7070600@samsung.com> <4F326D66.6060808@suse.de>
	<alpine.LNX.2.00.1202081903270.1498@linmac>
In-Reply-To: <alpine.LNX.2.00.1202081903270.1498@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Restore consistent formatting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: Blue Swirl <blauwirbel@gmail.com>, Dmitry Solodkiy <d.solodkiy@samsung.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Evgeny Voevodin <e.voevodin@samsung.com>, qemu-devel@nongnu.org

On 02/08/2012 09:04 AM, malc wrote:
> On Wed, 8 Feb 2012, Andreas F?rber wrote:
>
>> malc,
>>
>> Arbitrarily reformatting your files is not okay. If you want a different
>> formatting, you need to fix checkpatch.pl first to not error on that
>> formatting in your files.
>
> It was always formatter like this (internally consistent), then others
> added code which made it not so.

We do have a mixed style in the audio layer.  I'm not happy about that but I 
also feel strongly that going through and doing a reformat is not a worthwhile 
exercise.

I can also understand the desire to keep things consistent.  But patches should 
always go to the mailing list.  I certainly would have acked such a patch FWIW.

I think people get a bit too excited about coding style.  There are much more 
important things to worry about in life than the number of spaces before a 
parenthesis :-)

Regards,

Anthony Liguori

>
> [..snip..]
>