From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv9Z3-0000zJ-8E for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:36:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv9Yx-0001dB-Fd for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:36:09 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40588 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv9Yx-0001cy-5m for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:36:03 -0500 Message-ID: <4F329660.7040101@suse.de> Date: Wed, 08 Feb 2012 16:36:00 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4F324A60.7070600@samsung.com> <4F326D66.6060808@suse.de> <4F329385.4030203@codemonkey.ws> In-Reply-To: <4F329385.4030203@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Restore consistent formatting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Evgeny Voevodin , Stefan Hajnoczi , qemu-devel@nongnu.org, Blue Swirl , Dmitry Solodkiy Am 08.02.2012 16:23, schrieb Anthony Liguori: > On 02/08/2012 09:04 AM, malc wrote: >> On Wed, 8 Feb 2012, Andreas F?rber wrote: >> >>> Arbitrarily reformatting your files is not okay. If you want a differ= ent >>> formatting, you need to fix checkpatch.pl first to not error on that >>> formatting in your files. >> >> It was always formatter like this (internally consistent), then others >> added code which made it not so. >=20 > We do have a mixed style in the audio layer. I'm not happy about that > but I also feel strongly that going through and doing a reformat is not > a worthwhile exercise. >=20 > I can also understand the desire to keep things consistent. But patche= s > should always go to the mailing list. I certainly would have acked suc= h > a patch FWIW. >=20 > I think people get a bit too excited about coding style. There are muc= h > more important things to worry about in life than the number of spaces > before a parenthesis :-) This is not about whether or not we put a space somewhere. It's about reviewers and SubmitAPatch telling people to run checkpatch.pl on patches and checkpatch.pl reporting this as an ERROR, not a WARNING. So if you follow Stefan's instructions on running the script as a commit hook (which is the only sane way to run it when handling lots of patches) you can't commit a patch or your local changes when there are ERRORs. I just spent half the night trying to find out why checkpatch.pl reports CPUX86State *env, CPUYState *env, CPyState *env as ERRORs but not CPUState *env. I did not succeed in really understanding it. So either we need to all stop using and telling to use checkpatch.pl or someone needs to fix it. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg