From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv9lF-0004oD-42 for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:48:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rv9lA-0004Wu-72 for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:48:45 -0500 Received: from mail-pz0-f45.google.com ([209.85.210.45]:50080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rv9lA-0004Wm-2I for qemu-devel@nongnu.org; Wed, 08 Feb 2012 10:48:40 -0500 Received: by dadp14 with SMTP id p14so700720dad.4 for ; Wed, 08 Feb 2012 07:48:38 -0800 (PST) Message-ID: <4F329951.5060506@codemonkey.ws> Date: Wed, 08 Feb 2012 09:48:33 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <4F324A60.7070600@samsung.com> <4F326D66.6060808@suse.de> <4F329385.4030203@codemonkey.ws> <4F329660.7040101@suse.de> In-Reply-To: <4F329660.7040101@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] Restore consistent formatting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: Blue Swirl , Stefan Hajnoczi , qemu-devel@nongnu.org, Evgeny Voevodin , Dmitry Solodkiy On 02/08/2012 09:36 AM, Andreas Färber wrote: > Am 08.02.2012 16:23, schrieb Anthony Liguori: >> On 02/08/2012 09:04 AM, malc wrote: >>> On Wed, 8 Feb 2012, Andreas F?rber wrote: >>> >>>> Arbitrarily reformatting your files is not okay. If you want a different >>>> formatting, you need to fix checkpatch.pl first to not error on that >>>> formatting in your files. >>> >>> It was always formatter like this (internally consistent), then others >>> added code which made it not so. >> >> We do have a mixed style in the audio layer. I'm not happy about that >> but I also feel strongly that going through and doing a reformat is not >> a worthwhile exercise. >> >> I can also understand the desire to keep things consistent. But patches >> should always go to the mailing list. I certainly would have acked such >> a patch FWIW. >> >> I think people get a bit too excited about coding style. There are much >> more important things to worry about in life than the number of spaces >> before a parenthesis :-) > > This is not about whether or not we put a space somewhere. > > It's about reviewers and SubmitAPatch telling people to run > checkpatch.pl on patches and checkpatch.pl reporting this as an ERROR, > not a WARNING. So if you follow Stefan's instructions on running the > script as a commit hook (which is the only sane way to run it when > handling lots of patches) you can't commit a patch or your local changes > when there are ERRORs. It's a suggestion, it still assumes that you are going to exercise discretion and make rational decisions when checkpatch does something silly. > > I just spent half the night trying to find out why checkpatch.pl reports > CPUX86State *env, CPUYState *env, CPyState *env as ERRORs but not > CPUState *env. I did not succeed in really understanding it. > > So either we need to all stop using and telling to use checkpatch.pl or > someone needs to fix it. checkpatch.pl is a tool. Tools are meant to make our lives easier, not harder. You should use checkpatch.pl to help you figure out if you have coding style issues but it is not a QEMU maintainer that gives you a required Ack before you code gets accepted. If it's doing something stupid, ignore it. Making checkpatch 100% perfect (or event 99% perfect) is simply not worth the effort. Parsing C is insanely hard and doing it in perl only makes the problem worse :-) If you want to tone down the language in SubmitAPatch, please go ahead. It's a wiki after all. Regards, Anthony Liguori > > Andreas >