From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:39355)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RvUKZ-0001lL-74
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 08:46:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RvUKU-0002Z5-3E
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 08:46:35 -0500
Received: from mail-pw0-f45.google.com ([209.85.160.45]:50010)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RvUKT-0002Ys-T2
	for qemu-devel@nongnu.org; Thu, 09 Feb 2012 08:46:30 -0500
Received: by pbbro12 with SMTP id ro12so1753079pbb.4
	for <qemu-devel@nongnu.org>; Thu, 09 Feb 2012 05:46:28 -0800 (PST)
Message-ID: <4F33CE30.1040706@codemonkey.ws>
Date: Thu, 09 Feb 2012 07:46:24 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4F324A60.7070600@samsung.com>
	<4F326D66.6060808@suse.de>	<alpine.LNX.2.00.1202081903270.1498@linmac>	<4F329385.4030203@codemonkey.ws>
	<m3k43wcp7z.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3k43wcp7z.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Restore consistent formatting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, =?ISO-8859-1?Q?Andreas_F=E4r?= =?ISO-8859-1?Q?ber?= <afaerber@suse.de>, qemu-devel@nongnu.org, Evgeny Voevodin <e.voevodin@samsung.com>, Dmitry Solodkiy <d.solodkiy@samsung.com>

On 02/09/2012 03:48 AM, Markus Armbruster wrote:
> Anthony Liguori<anthony@codemonkey.ws>  writes:
>
>> On 02/08/2012 09:04 AM, malc wrote:
>>> On Wed, 8 Feb 2012, Andreas F?rber wrote:
>>>
>>>> malc,
>>>>
>>>> Arbitrarily reformatting your files is not okay. If you want a different
>>>> formatting, you need to fix checkpatch.pl first to not error on that
>>>> formatting in your files.
>>>
>>> It was always formatter like this (internally consistent), then others
>>> added code which made it not so.
>>
>> We do have a mixed style in the audio layer.  I'm not happy about that
>> but I also feel strongly that going through and doing a reformat is
>> not a worthwhile exercise.
>>
>> I can also understand the desire to keep things consistent.  But
>> patches should always go to the mailing list.  I certainly would have
>> acked such a patch FWIW.
>
> You buried the one truly important sentence, let me dig it out for you:
>
>          *** Patches should always go to the mailing list ***
>
> Exceptions need justification.  Responsible handling embargoed security
> issues may qualify.  Style fixes certainly not.

100% agreed.

Regards,

Anthony Liguori


>
> [...]
>