From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932171Ab2BNANJ (ORCPT ); Mon, 13 Feb 2012 19:13:09 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:47835 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758567Ab2BNANE (ORCPT ); Mon, 13 Feb 2012 19:13:04 -0500 Message-ID: <4F39A705.9050207@nod.at> Date: Tue, 14 Feb 2012 01:12:53 +0100 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120129 Thunderbird/10.0 MIME-Version: 1.0 To: Pablo Neira Ayuso CC: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eric.dumazet@gmail.com, jengelh@medozas.de, rostedt@goodmis.org, basti@b-bl.de Subject: Re: [PATCH 4/4] Netfilter: xt_LOG: Implement ring buffer support References: <1328911856-19260-1-git-send-email-richard@nod.at> <1328911856-19260-7-git-send-email-richard@nod.at> <20120214001123.GA24194@1984> In-Reply-To: <20120214001123.GA24194@1984> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.02.2012 01:11, schrieb Pablo Neira Ayuso: > On Fri, Feb 10, 2012 at 11:10:56PM +0100, Richard Weinberger wrote: >> This patch introduces NETFILTER_XT_TARGET_LOG_RING. >> It allows logging into various ring buffers which are >> represented as pipe-like files in /proc/net/netfilter/xt_LOG_ring/. >> >> Signed-off-by: Richard Weinberger >> --- >> include/linux/netfilter/xt_LOG.h | 13 +- >> include/net/netfilter/nf_log.h | 1 + >> include/net/netfilter/xt_log_ring.h | 24 ++ > > Could merge xt_log_ring.h with xt_log.h? Sure. >> net/netfilter/Kconfig | 13 + >> net/netfilter/xt_LOG.c | 642 ++++++++++++++++++++++++++++++++++- >> 5 files changed, 674 insertions(+), 19 deletions(-) >> create mode 100644 include/net/netfilter/xt_log_ring.h >> >> diff --git a/include/linux/netfilter/xt_LOG.h b/include/linux/netfilter/xt_LOG.h >> index cac0790..d84710c 100644 >> --- a/include/linux/netfilter/xt_LOG.h >> +++ b/include/linux/netfilter/xt_LOG.h >> @@ -8,7 +8,8 @@ >> #define XT_LOG_UID 0x08 /* Log UID owning local socket */ >> #define XT_LOG_NFLOG 0x10 /* Unsupported, don't reuse */ >> #define XT_LOG_MACDECODE 0x20 /* Decode MAC header */ >> -#define XT_LOG_MASK 0x2f >> +#define XT_LOG_ADD_TIMESTAMP 0x40 /* Add a timestamp */ > > Please, I'd appreciate if you can split this timestamp support in a > separated patch. > Will do. Thanks, //richard